From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbbINVMp (ORCPT ); Mon, 14 Sep 2015 17:12:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45450 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbbINVMo (ORCPT ); Mon, 14 Sep 2015 17:12:44 -0400 Date: Mon, 14 Sep 2015 14:12:43 -0700 From: Greg Kroah-Hartman To: Mikael Pettersson Cc: Peter Hurley , linux-kernel@vger.kernel.org Subject: Re: [4.3-rc1 regression] modular 8250 doesn't load Message-ID: <20150914211243.GA3377@kroah.com> References: <22006.65274.114552.472501@gargle.gargle.HOWL> <20150914175713.GA8384@kroah.com> <22007.3229.404183.315075@gargle.gargle.HOWL> <20150914185052.GA10687@kroah.com> <22007.12592.340250.148887@gargle.gargle.HOWL> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22007.12592.340250.148887@gargle.gargle.HOWL> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2015 at 10:42:24PM +0200, Mikael Pettersson wrote: > Greg Kroah-Hartman writes: > > On Mon, Sep 14, 2015 at 08:06:21PM +0200, Mikael Pettersson wrote: > > > Greg Kroah-Hartman writes: > > > > On Mon, Sep 14, 2015 at 07:08:10PM +0200, Mikael Pettersson wrote: > > > > > I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked > > > > > and resulted in: > > > > > > > > > > [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled > > > > > [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A > > > > > > > > > > With 4.3-rc1 however the command fails and logs the following: > > > > > > > > > > [ 34.140300] 8250_base: module license 'unspecified' taints kernel. > > > > > > > > Oops, need to fix that. > > > > > > > > > [ 34.141846] Disabling lock debugging due to kernel taint > > > > > [ 34.143388] 8250_base: Unknown symbol uart_insert_char (err 0) > > > > > [ 34.144908] 8250_base: Unknown symbol uart_handle_dcd_change (err 0) > > > > > [ 34.146439] 8250_base: Unknown symbol __pm_runtime_resume (err 0) > > > > > [ 34.147901] 8250_base: Unknown symbol tty_termios_encode_baud_rate (err 0) > > > > > [ 34.149354] 8250_base: Unknown symbol uart_handle_cts_change (err 0) > > > > > [ 34.150798] 8250_base: Unknown symbol __pm_runtime_suspend (err 0) > > > > > [ 34.152240] 8250_base: Unknown symbol nr_irqs (err 0) > > > > > > > > Are you sure you did 'modprobe' and not 'insmod'? > > > > > > Yes, I used modprobe. I double-checked. > > > > Then your build should have failed if these functions are not being > > exported properly by your .config. Most of these are in the serial_core > > module, is that present/loaded? > > Yes, serial_core is loaded. > > uart_insert_char is EXPORT_SYMBOL_GPL, so could the missing license tag be preventing > 8250_core from binding to it? (I haven't checked the other symbols but I assume they > are also _GPL.) Ah, crap, yes, you are right. You can test this with a simple: MODULE_LICENSE("GPL"); line added to the 8250_base file. thanks, greg k-h