From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbbIOH7s (ORCPT ); Tue, 15 Sep 2015 03:59:48 -0400 Received: from relay.parallels.com ([195.214.232.42]:33580 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbbIOH7r (ORCPT ); Tue, 15 Sep 2015 03:59:47 -0400 Date: Tue, 15 Sep 2015 10:59:24 +0300 From: Vladimir Davydov To: Raghavendra K T CC: , , , , , , , , , , , Subject: Re: [PATCH V2 1/2] mm: Replace nr_node_ids for loop with for_each_node in list lru Message-ID: <20150915075924.GD16220@esperanza> References: <1442282917-16893-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <1442282917-16893-2-git-send-email-raghavendra.kt@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1442282917-16893-2-git-send-email-raghavendra.kt@linux.vnet.ibm.com> X-ClientProxiedBy: US-EXCH.sw.swsoft.com (10.255.249.47) To MSK-EXCH1.sw.swsoft.com (10.67.48.55) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2015 at 07:38:36AM +0530, Raghavendra K T wrote: > The functions used in the patch are in slowpath, which gets called > whenever alloc_super is called during mounts. > > Though this should not make difference for the architectures with > sequential numa node ids, for the powerpc which can potentially have > sparse node ids (for e.g., 4 node system having numa ids, 0,1,16,17 > is common), this patch saves some unnecessary allocations for > non existing numa nodes. > > Even without that saving, perhaps patch makes code more readable. > > [ Take memcg_aware check outside for_each loop: Vldimir] > Signed-off-by: Raghavendra K T Reviewed-by: Vladimir Davydov