From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbbIOIOx (ORCPT ); Tue, 15 Sep 2015 04:14:53 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:33960 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbbIOIOt (ORCPT ); Tue, 15 Sep 2015 04:14:49 -0400 Date: Tue, 15 Sep 2015 13:44:45 +0530 From: Viresh Kumar To: Rafael Wysocki Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Thomas Gleixner , alexandra.yates@linux.intel.com, open list Subject: Re: [PATCH] cpufreq: cpufreq_cpu_get_raw() isn't a static function anymore Message-ID: <20150915081445.GD6350@linux> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-09-15, 13:40, Viresh Kumar wrote: > Its used outside of the core file and is exported as well. Drop the > 'static' keyword from its declaration and fix below build error: > > linux/drivers/cpufreq/cpufreq.c:241:31: error: static declaration of > 'cpufreq_cpu_get_raw' follows non-static declaration > > Fixes: 503655f70d9b ("cpufreq: acpi-cpufreq: Use cpufreq_cpu_get_raw() in ->get()") > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Urg, sorry for spamming wrong people (Thomas/Alexandra) for an unrelated patch. Have sent the relevant patch with this subject now: "PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG" Though, this fix was also relevant, just sent it to wrong people :( > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index a8252bb0f80c..ef5ed9470de9 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -238,7 +238,7 @@ int cpufreq_generic_init(struct cpufreq_policy *policy, > } > EXPORT_SYMBOL_GPL(cpufreq_generic_init); > > -static struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu) > +struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu) > { > struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu); > > -- > 2.4.0 > -- viresh