public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Dan Murphy" <dmurphy@ti.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency
Date: Tue, 15 Sep 2015 11:32:24 +0300	[thread overview]
Message-ID: <20150915083224.GA3166@lpalcu-desk> (raw)
In-Reply-To: <1442265973-32261-3-git-send-email-afd@ti.com>

On Mon, Sep 14, 2015 at 04:26:08PM -0500, Andrew F. Davis wrote:
> Rename functions that are used by multiple devices. New devices
> have been added and the function names and driver name are no longer
> general enough for the functionality they provide.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  MAINTAINERS                                        |   4 +-
>  arch/arm/configs/omap2plus_defconfig               |   2 +-
>  arch/unicore32/Kconfig                             |   2 +-
>  drivers/power/Kconfig                              |  22 +-
>  drivers/power/Makefile                             |   2 +-
>  .../power/{bq27x00_battery.c => bq27xxx_battery.c} | 333 +++++++++++----------

1000 chips! That's how many potential chips is this driver supposed to
support, after the rename, with little or no modifications. Is it even
possible to guarantee that all future chips, starting with 'bq27' in
their naming scheme, are register compatible?

Call me conservative, but when I see driver names/renames containing
wildcards, I get chills down my spine. I can probably get over single
digit wildcards but 3 digit wildcards is a little too much. :)

I can't help but wonder what will one have to do if one single newly
released bq27xxx chip is completely different... :/

laurentiu



  reply	other threads:[~2015-09-15  8:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 21:26 [PATCH v4 0/7] Add support for additional bq27xxx devices Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS Andrew F. Davis
2015-09-21  8:33   ` Pali Rohár
2015-09-22 15:18   ` Sebastian Reichel
2015-09-14 21:26 ` [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency Andrew F. Davis
2015-09-15  8:32   ` Laurentiu Palcu [this message]
2015-09-15 16:53     ` Andrew F. Davis
2015-09-22 16:10   ` Sebastian Reichel
2015-09-14 21:26 ` [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device Andrew F. Davis
2015-09-21  8:41   ` Pali Rohár
2015-09-21 18:40     ` Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 4/7] power: bq27xxx_battery: Fix typos and change naming for state of charge functions Andrew F. Davis
2015-09-21  8:36   ` Pali Rohár
2015-09-14 21:26 ` [PATCH v4 5/7] power: bq27xxx_battery: Add support for additional bq27xxx family devices Andrew F. Davis
2015-09-21  8:46   ` Pali Rohár
2015-09-21 19:02     ` Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 6/7] power: bq27xxx_battery: Cleanup health checking Andrew F. Davis
2015-09-21  8:35   ` Pali Rohár
2015-09-14 21:26 ` [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling support Andrew F. Davis
2015-09-15 18:47   ` Andreas Dannenberg
2015-09-15 20:53     ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150915083224.GA3166@lpalcu-desk \
    --to=laurentiu.palcu@intel.com \
    --cc=afd@ti.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dmurphy@ti.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox