From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbbIONG3 (ORCPT ); Tue, 15 Sep 2015 09:06:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36867 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbbIONG0 (ORCPT ); Tue, 15 Sep 2015 09:06:26 -0400 Date: Tue, 15 Sep 2015 10:06:19 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , mingo@kernel.org, kan.liang@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps Message-ID: <20150915130619.GA2346@redhat.com> References: <1441699142-18905-1-git-send-email-adrian.hunter@intel.com> <20150908080858.GC2038@krava.brq.redhat.com> <55F7C048.2000203@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55F7C048.2000203@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Sep 15, 2015 at 09:52:56AM +0300, Adrian Hunter escreveu: > On 08/09/15 11:08, Jiri Olsa wrote: > > On Tue, Sep 08, 2015 at 10:58:48AM +0300, Adrian Hunter wrote: > >> Hi > >> > >> Here is V3 of "Fix gaps propagating maps" that fixes some problems > >> revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads") > >> > >> Changes in V3: > >> > >> perf tools: Remove redundant validation from perf_evlist__propagate_maps > >> perf_evlist__set_maps also doesn't need to return an error anymore > >> > >> perf tools: Add evlist->has_user_cpus > >> Adjusted due to perf_evlist__set_maps change > >> > >> perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps() > >> Adjusted due to perf_evlist__set_maps change > >> > >> perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps > >> Adjusted due to perf_evlist__set_maps change > >> > >> perf tools: Fix task exit test setting maps > >> Adjusted due to perf_evlist__set_maps change > >> > >> perf tools: Fix software clock events test setting maps > >> Adjusted due to perf_evlist__set_maps change > > > > Acked-by: Jiri Olsa > > Hi Arnaldo > > Please don't forget these. Intel PT is broken on 4.3 without them i.e. > > $ tools/perf/perf --version > perf version 4.3.rc1.gd25ed > $ tools/perf/perf record -e intel_pt//u uname > Error: > The sys_perf_event_open() syscall returned with 22 (Invalid argument) for > event (sched:sched_switch). Ok, so this needs to go to perf/urgent, checking them now. - Arnaldo