From: Andy Whitcroft <apw@canonical.com>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: joe@perches.com,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>
Subject: Re: possible new false positive in checkpatch
Date: Tue, 15 Sep 2015 16:01:23 +0100 [thread overview]
Message-ID: <20150915150123.GU19632@bark> (raw)
In-Reply-To: <CAFDyS3P1f9nV4iJLD7fR19KPUN_VOiBv3JR311WEAKgdPdX8dw@mail.gmail.com>
On Tue, Sep 15, 2015 at 05:50:40PM +0300, Tal Shorer wrote:
> > Yes it feels like that should be eliding them completely, and likely any
> > following space as well, something like this:
> >
> > $s =~ s/$;+\s*//g;
> > $c =~ s/$;+\s*//g;
> >
> Replacing the problematic lines with these fixes the issue.
> > > Introduced in commit 9f5af480f4554aac12e002b6f5c2b04895857700:
> > > checkpatch: improve SUSPECT_CODE_INDENT test
> > > Commenting out these lines removes the warning.
> > >
> > > This pattern exists in many places around the kernel source.
> > > Is this the intended behavior?
> >
> > Seems wrong to me.
> >
> > -apw
>
> Which git tree is checkpatch developed in? Linus's?
Yeah in Linus' tree.
-apw
next prev parent reply other threads:[~2015-09-15 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 12:13 possible new false positive in checkpatch Tal Shorer
2015-09-14 10:27 ` Andy Whitcroft
2015-09-15 14:50 ` Tal Shorer
2015-09-15 15:01 ` Andy Whitcroft [this message]
2015-10-26 16:43 ` Tal Shorer
2016-06-11 7:33 ` Tal Shorer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915150123.GU19632@bark \
--to=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tal.shorer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox