From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752949AbbIOPBa (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Sep 2015 11:01:30 -0400
Received: from mail-wi0-f176.google.com ([209.85.212.176]:37202 "EHLO
	mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752151AbbIOPB2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Sep 2015 11:01:28 -0400
Date: Tue, 15 Sep 2015 16:01:23 +0100
From: Andy Whitcroft <apw@canonical.com>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: joe@perches.com,
        "<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>
Subject: Re: possible new false positive in checkpatch
Message-ID: <20150915150123.GU19632@bark>
References: <1442060011-3996-1-git-send-email-tal.shorer@gmail.com>
 <20150914102749.GR19632@bark>
 <CAFDyS3P1f9nV4iJLD7fR19KPUN_VOiBv3JR311WEAKgdPdX8dw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFDyS3P1f9nV4iJLD7fR19KPUN_VOiBv3JR311WEAKgdPdX8dw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 15, 2015 at 05:50:40PM +0300, Tal Shorer wrote:

> > Yes it feels like that should be eliding them completely, and likely any
> > following space as well, something like this:
> >
> >         $s =~ s/$;+\s*//g;
> >         $c =~ s/$;+\s*//g;
> >
> Replacing the problematic lines with these fixes the issue.
> > > Introduced in commit 9f5af480f4554aac12e002b6f5c2b04895857700:
> > > checkpatch: improve SUSPECT_CODE_INDENT test
> > > Commenting out these lines removes the warning.
> > >
> > > This pattern exists in many places around the kernel source.
> > > Is this the intended behavior?
> >
> > Seems wrong to me.
> >
> > -apw
> 
> Which git tree is checkpatch developed in? Linus's?

Yeah in Linus' tree.

-apw