From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbbIOPa7 (ORCPT ); Tue, 15 Sep 2015 11:30:59 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50580 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752546AbbIOPa4 (ORCPT ); Tue, 15 Sep 2015 11:30:56 -0400 Date: Tue, 15 Sep 2015 17:30:53 +0200 From: Maxime Ripard To: yassinjaffer@gmail.com Cc: linux-sunxi@googlegroups.com, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] devicetree: bindings:Allwinner sun4i keypad Message-ID: <20150915153053.GO4684@lukather> References: <1442325957-10102-1-git-send-email-yassinjaffer@gmail.com> <1442325957-10102-5-git-send-email-yassinjaffer@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="de1H0RjRxOSdb4we" Content-Disposition: inline In-Reply-To: <1442325957-10102-5-git-send-email-yassinjaffer@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --de1H0RjRxOSdb4we Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 16, 2015 at 12:05:57AM +1000, yassinjaffer@gmail.com wrote: > From: Yassin Jaffer >=20 > Signed-off-by: Yassin Jaffer > --- > .../devicetree/bindings/input/sun4i-keypad.txt | 56 ++++++++++++++++= ++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/sun4i-keypad.= txt >=20 > diff --git a/Documentation/devicetree/bindings/input/sun4i-keypad.txt b/D= ocumentation/devicetree/bindings/input/sun4i-keypad.txt > new file mode 100644 > index 0000000..60ed0f2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/sun4i-keypad.txt > @@ -0,0 +1,56 @@ > +Allwinner sun4i keypad > +------------------------------------------------ > + > +Required properties: > + - compatible: "allwinner,sun4i-a10-keypad" > + - reg: mmio address range of the chip > + - interrupts: interrupt to which the chip is connected > + - clocks : shall reference keypad controller clocks. > + - clock-names : keypad controller internal clock names. Shall contain : > + * "apb" : APB gating clock > + * "keypad" : keypad controller clock > + > +Required Board Specific Properties: > +- pinctrl-names: The definition can be found at > +pinctrl/pinctrl-bindings.txt. > + > +- pinctrl-0: The definition can be found at > +pinctrl/pinctrl-bindings.txt. > + > +- linux,keymap: The definition can be found at > +bindings/input/matrix-keymap.txt. > + > +Optional properties: > + - scan-cycle: device specific scan cycle > + - debounce-cycle: device specific debounce cycle > + - autorepeat: If specified device will autorepeat Are those properties generic? I couldn't find them defined anywhere. In which units are those properties? > + > +Example: > + > +#include > + > + kp: kp@01c23000 { > + compatible =3D "allwinner,sun4i-a10-keypad"; > + reg =3D <0x01c23000 0x400>; > + interrupts =3D ; > + clocks =3D <&apb0_gates 10>, <&keypad_clk>; > + clock-names =3D "apb", "keypad"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&keypad_rows>, <&keypad_cols>; > + linux,keymap =3D <0x00000067 /* KEY_UP */ > + 0x0001006c /* KEY_DOWN */ > + 0x00020072 /* KEY_VOLUMEDOWN */ > + 0x00030066 /* KEY_HOME */ > + 0x0100006a /* KEY_RIGHT */ > + 0x01010069 /* KEY_LEFT */ > + 0x0102001c /* KEY_ENTER */ > + 0x01030073 /* KEY_VOLUMEUP */ > + 0x02000040 /* KEY_F6 */ > + 0x02010042 /* KEY_F8 */ > + 0x02020043 /* KEY_F9 */ > + 0x02030044 /* KEY_F10 */ > + 0x0300003b /* KEY_F1 */ > + 0x0301003c /* KEY_F2 */ > + 0x0302003d /* KEY_F3 */ > + 0x03030074>; /* KEY_POWER */ You don't seem to use the header you just told us to include. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --de1H0RjRxOSdb4we Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV+DmtAAoJEBx+YmzsjxAgO1AQAJhEyjxa3LsRmfvvutIxBe0t X3XTcEj6pBw+U9UBxlwuH+lgFArF1YLoADgxXnACCzErn5r3ZCRsdP2JAH9T+iNS nXK2LJwdq12ImJMd7mIMLTcs4JmLQZXQKW5jpmj3cC9S3kCLOK76AA9xpbUz0avn xJQp6QsodCd3Qj5jF5zFx++Ceu1OGHcKBfA2r2R2jh8ZDteMLEgtWgfRbKZylYwm iuD6j5xtFD/HhqwFTwKs/36J0m8TbwpfjTeg++ZoPQGK+0wxrPNlWUVaEwUEYvtt iSAUq1EcAXM/dajp1dTsgBdVQJpRvi63pswQkTPMKsnrGrXmpviMpDKIFikmj9Xg aYOHjjIFDFwMxLSiFSzgyEZThK6xGanx1ooVLo9EsL+0xwSZBRypi0uB5px7LuKB 8JSEt2U5R0V09BTBbu+C1xvWI/jzKlV3zsSU9dyxkJz6l8/fC5AVRiEOhP/iVKZo lmLsbJTmRFfk2AESqeC1LtHEh8IJh59CFGSp/AHmWodxJ+tDR0sACPzyEcYOYQ+f 7vvpSXkHG0qOFMd/I5bFqfdFfS6w/MKDE69iC8R3ylDqDTV7lgZtorIyNrR2ElbD +QNl9QE726ov0Lr7RSKjDc7C/3Ra7CVrvyfeNHEi0pa218VNXZhwuxBOpy3Pb6G6 +SdbBv4mteimrh6sV0HE =bhO/ -----END PGP SIGNATURE----- --de1H0RjRxOSdb4we--