From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbbIPCA3 (ORCPT ); Tue, 15 Sep 2015 22:00:29 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33360 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbbIPCA1 (ORCPT ); Tue, 15 Sep 2015 22:00:27 -0400 Date: Wed, 16 Sep 2015 07:30:23 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Thomas Gleixner , alexandra.yates@linux.intel.com, Len Brown , open list , Pavel Machek Subject: Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG Message-ID: <20150916020023.GB29235@linux> References: <4171587.Rkb7nBLebe@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4171587.Rkb7nBLebe@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-09-15, 03:43, Rafael J. Wysocki wrote: > On Tuesday, September 15, 2015 01:42:21 PM Viresh Kumar wrote: > > The variable 'wakeup_irq' is defined within #ifdef CONFIG_PM_SLEEP_DEBUG > > and used outside of it. And that breaks kernel build: > > > > /home/viresh/linux/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq' > > /home/viresh/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq' > > > > Fix it by defining the variable outside of the ifdef. > > > > Fixes: d1e59c235322 ("PM / sleep: Report interrupt that caused system wakeup") > > Signed-off-by: Viresh Kumar > > I've applied the v11 of the Alexandra's patch that doesn't have this problem AFAICS. For the record, as we have talked on IRC, even the v11 patch suffers from this problem and you will be fixing it. -- viresh