From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Tim Spriggs <tspriggs@apple.com>,
davej@codemonkey.org.uk, sasha.levin@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: unpinning an unpinned lock
Date: Wed, 16 Sep 2015 12:55:35 +0200 [thread overview]
Message-ID: <20150916105535.GD3816@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150915214244.GS4029@linux.vnet.ibm.com>
On Tue, Sep 15, 2015 at 02:42:44PM -0700, Paul E. McKenney wrote:
> > All nodes report from: kernel/locking/lockdep.c:3497 lock_unpin_lock+0xed/0xf0()
>
> > [<ffffffff810a49dd>] lock_unpin_lock+0xed/0xf0
> > [<ffffffff810962f1>] pick_next_task_fair+0x51/0x220
> > [<ffffffff816b2c9c>] __schedule+0x12c/0x990
> > [<ffffffff816b367e>] schedule+0x3e/0x80
> > [<ffffffff810a49dd>] lock_unpin_lock+0xed/0xf0
> > [<ffffffff816b2f21>] __schedule+0x3b1/0x990
> > [<ffffffff816b367e>] schedule+0x3e/0x80
Right, Sasha was reporting these too, I've not been able to reproduce
and neither have I been able to make sense of the extra debug bits Sasha
generated :/
I've even completely reimplemented the feature from scratch and compared
to see if I missed something -- either I'm being very consistent with my
mistakes or something else is happening.
In any case, I'll have another go at tackling this, otherwise I'll have
to disable this warning for now.
Note that this lockdep 'feature' is pure annotation, no actual logic was
changed.
next prev parent reply other threads:[~2015-09-16 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C137BC9E-19DB-4D41-A9BE-DFE2AEE7CF42@apple.com>
2015-09-15 21:42 ` unpinning an unpinned lock Paul E. McKenney
2015-09-16 10:55 ` Peter Zijlstra [this message]
2015-09-16 14:10 ` Peter Zijlstra
2015-09-18 13:35 ` Sasha Levin
2015-09-23 8:46 ` [tip:locking/core] locking/lockdep: Fix hlock-> pin_count reset on lock stack rebuilds tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916105535.GD3816@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sasha.levin@oracle.com \
--cc=tspriggs@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox