From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753658AbbIPOQT (ORCPT ); Wed, 16 Sep 2015 10:16:19 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53092 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753338AbbIPOQP (ORCPT ); Wed, 16 Sep 2015 10:16:15 -0400 Date: Wed, 16 Sep 2015 07:16:14 -0700 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Alexander Viro , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Artem Bityutskiy , Adrian Hunter , linux-mtd@lists.infradead.org, Richard Weinberger , Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net Subject: Re: [PATCH 4/5] xattr handlers: Pass handler to operations instead of flags Message-ID: <20150916141614.GB16005@infradead.org> References: <1441367842-25079-1-git-send-email-agruenba@redhat.com> <1441367842-25079-5-git-send-email-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441367842-25079-5-git-send-email-agruenba@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 01:57:21PM +0200, Andreas Gruenbacher wrote: > The xattr_handler operations are currently all passed a file system specific > flags value which the operations can use to disambiguate between different > handlers; some file systems use that to distinguish the xattr namespace, for > example. In some oprations, it would be useful to also have access to the > handler prefix. To allow that, pass a pointer to the handler to operations > instead of the flags value alone. Looks ok, but the more usual calling convention would be to pass the handler as the first argument.