* [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver
@ 2015-09-15 16:31 Luis de Bethencourt
2015-09-16 17:48 ` Tejun Heo
2015-09-16 19:23 ` Tejun Heo
0 siblings, 2 replies; 4+ messages in thread
From: Luis de Bethencourt @ 2015-09-15 16:31 UTC (permalink / raw)
To: linux-kernel; +Cc: Bartlomiej Zolnierkiewicz, Tejun Heo, linux-ide
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.
Link: https://lkml.org/lkml/2015/7/30/519
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
drivers/ata/pata_macio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index b002858..e60adbb 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1344,6 +1344,7 @@ static struct of_device_id pata_macio_match[] =
},
{},
};
+MODULE_DEVICE_TABLE(of, pata_macio_patch);
static struct macio_driver pata_macio_driver =
{
--
2.4.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver
2015-09-15 16:31 [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-16 17:48 ` Tejun Heo
2015-09-16 18:58 ` Luis de Bethencourt
2015-09-16 19:23 ` Tejun Heo
1 sibling, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2015-09-16 17:48 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: linux-kernel, Bartlomiej Zolnierkiewicz, linux-ide
On Tue, Sep 15, 2015 at 06:31:14PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> Link: https://lkml.org/lkml/2015/7/30/519
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Where should this patch be applied? for-4.4? for-4.3-fixes w/ or w/o
stable cc'd?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver
2015-09-16 17:48 ` Tejun Heo
@ 2015-09-16 18:58 ` Luis de Bethencourt
0 siblings, 0 replies; 4+ messages in thread
From: Luis de Bethencourt @ 2015-09-16 18:58 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-kernel, Bartlomiej Zolnierkiewicz, linux-ide
On Wed, Sep 16, 2015 at 01:48:23PM -0400, Tejun Heo wrote:
> On Tue, Sep 15, 2015 at 06:31:14PM +0200, Luis de Bethencourt wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> > that information so modules have the correct aliases built-in and
> > autoloading works correctly.
> >
> > Link: https://lkml.org/lkml/2015/7/30/519
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>
> Where should this patch be applied? for-4.4? for-4.3-fixes w/ or w/o
> stable cc'd?
>
> Thanks.
>
> --
> tejun
Hi Tejun,
Other drivers with the same problem are applying this in 4.3-fixes.
I don't think it is critical enough to deserve a cc: Stable.
Thanks for review,
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver
2015-09-15 16:31 [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-16 17:48 ` Tejun Heo
@ 2015-09-16 19:23 ` Tejun Heo
1 sibling, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2015-09-16 19:23 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: linux-kernel, Bartlomiej Zolnierkiewicz, linux-ide
On Tue, Sep 15, 2015 at 06:31:14PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> Link: https://lkml.org/lkml/2015/7/30/519
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Applied to libata/for-4.3-fixes.
Thanks!
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-16 19:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-15 16:31 [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-16 17:48 ` Tejun Heo
2015-09-16 18:58 ` Luis de Bethencourt
2015-09-16 19:23 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).