From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Ivan Grimaldi <grimaldi.ivan@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Mark Jackson <mpfj@mimc.co.uk>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH] Fixed ds1390_get_reg returned value
Date: Wed, 16 Sep 2015 20:10:57 +0200 [thread overview]
Message-ID: <20150916181057.GF4287@piout.net> (raw)
In-Reply-To: <CAO1575Wk_O6RYMGJSx2=54OYj-_fZXSGum5bZa8fF=cpf5d5Gw@mail.gmail.com>
Hi,
Your patch is not properly fomatted, it as probably been mangled by your
mailer can you resend it properly?
Thanks,
On 16/09/2015 at 17:51:17 +0200, Ivan Grimaldi wrote :
> spi_write_then_read puts in rx_buf the received data starting from the
> first byte of the rx_buf for n_rx bytes.
>
> Signed-off-by: Ivan Grimaldi <grimaldi.ivan@gmail.com>
> ---
> diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
> index e67bfcb..a4303b4 100644
> --- a/drivers/rtc/rtc-ds1390.c
> +++ b/drivers/rtc/rtc-ds1390.c
> @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned
> char address,
> if (status != 0)
> return status;
>
> - *data = chip->txrx_buf[1];
> + *data = chip->txrx_buf[0];
>
> return 0;
> }
>
> --
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
> ---
> You received this message because you are subscribed to the Google Groups "rtc-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
parent reply other threads:[~2015-09-16 18:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAO1575Wk_O6RYMGJSx2=54OYj-_fZXSGum5bZa8fF=cpf5d5Gw@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916181057.GF4287@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=grimaldi.ivan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpfj@mimc.co.uk \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox