From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbbIPSLL (ORCPT ); Wed, 16 Sep 2015 14:11:11 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45022 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752633AbbIPSLK (ORCPT ); Wed, 16 Sep 2015 14:11:10 -0400 Date: Wed, 16 Sep 2015 20:10:57 +0200 From: Alexandre Belloni To: Ivan Grimaldi Cc: Alessandro Zummo , Mark Jackson , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [rtc-linux] [PATCH] Fixed ds1390_get_reg returned value Message-ID: <20150916181057.GF4287@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Your patch is not properly fomatted, it as probably been mangled by your mailer can you resend it properly? Thanks, On 16/09/2015 at 17:51:17 +0200, Ivan Grimaldi wrote : > spi_write_then_read puts in rx_buf the received data starting from the > first byte of the rx_buf for n_rx bytes. > > Signed-off-by: Ivan Grimaldi > --- > diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c > index e67bfcb..a4303b4 100644 > --- a/drivers/rtc/rtc-ds1390.c > +++ b/drivers/rtc/rtc-ds1390.c > @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned > char address, > if (status != 0) > return status; > > - *data = chip->txrx_buf[1]; > + *data = chip->txrx_buf[0]; > > return 0; > } > > -- > -- > You received this message because you are subscribed to "rtc-linux". > Membership options at http://groups.google.com/group/rtc-linux . > Please read http://groups.google.com/group/rtc-linux/web/checklist > before submitting a driver. > --- > You received this message because you are subscribed to the Google Groups "rtc-linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com