From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753462AbbIPUA0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Sep 2015 16:00:26 -0400
Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:32080 "EHLO
	m0041696.ppops.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752220AbbIPUAY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Sep 2015 16:00:24 -0400
Date: Wed, 16 Sep 2015 16:00:12 -0400
From: Chris Mason <clm@fb.com>
To: Jan Kara <jack@suse.cz>
CC: Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Chinner <david@fromorbit.com>, Josef Bacik <jbacik@fb.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Neil Brown <neilb@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()
Message-ID: <20150916200012.GB8624@ret.masoncoding.com>
Mail-Followup-To: Chris Mason <clm@fb.com>, Jan Kara <jack@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Chinner <david@fromorbit.com>, Josef Bacik <jbacik@fb.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Neil Brown <neilb@suse.de>, Christoph Hellwig <hch@lst.de>
References: <55F33C2B.1010508@fb.com>
 <CA+55aFyK3Ua2ZcKLUBvESzxh=pH4x28QeijypJvSPiWbZStV-g@mail.gmail.com>
 <CA+55aFxpd0qrzb_4WamkYekiOXsi5Bs69kK8uj_Xg6MSYs4QtA@mail.gmail.com>
 <20150911231636.GC4150@ret.masoncoding.com>
 <CA+55aFx=HdDMhK0bL8aNxOS83M3EOKGCLY59QzTF-jT+MPHXBw@mail.gmail.com>
 <20150912230027.GE4150@ret.masoncoding.com>
 <20150913231258.GS26895@dastard>
 <CA+55aFxYQ4bfBbyG97W=Yrzf+tpezrvktBBb=DmFX1we2+mdrw@mail.gmail.com>
 <20150916151621.GA8624@ret.masoncoding.com>
 <20150916195806.GD29530@quack.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20150916195806.GD29530@quack.suse.cz>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
X-Originating-IP: [192.168.52.123]
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000
 definitions=2015-09-16_05:2015-09-16,2015-09-16,1970-01-01 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 16, 2015 at 09:58:06PM +0200, Jan Kara wrote:
> On Wed 16-09-15 11:16:21, Chris Mason wrote:
> > Short version, Linus' patch still gives bigger IOs and similar perf to
> > Dave's original.  I should have done the blktrace runs for 60 seconds
> > instead of 30, I suspect that would even out the average sizes between
> > the three patches.
> 
> Thanks for the data Chris. So I guess we are fine with what's currently in,
> right?

Looks like it works well to me.

-chris