From: Greg KH <gregkh@linuxfoundation.org>
To: Eric Curtin <ericcurtin17@gmail.com>
Cc: Austin S Hemmelgarn <ahferroin7@gmail.com>,
Steve Calfee <stevecalfee@gmail.com>,
Valentina Manea <valentina.manea.m@gmail.com>,
shuah.kh@samsung.com, USB list <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: First kernel patch (optimization)
Date: Wed, 16 Sep 2015 13:02:10 -0700 [thread overview]
Message-ID: <20150916200210.GA6341@kroah.com> (raw)
In-Reply-To: <CANpvso7dcMn2u8of8UDgBdVCx=M6g_VCuqvA8Dt6gkvwPTA6kw@mail.gmail.com>
On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote:
> Hi Greg,
>
> As I said in the subject of the mail (which I have been since told I
> shouldn't have done this), I'm a noob to kernel code. I tried to pick
> off something super simple to just see what the process of getting a
> patch in is. Youtube videos and documentation only get you so far.
>
> >From reading your response, should I refrain from sending in these
> micro-optimizations in future? Getting in smaller patches is easier
> for me as I only do this in my spare time, which I don't have a lot
> of!
micro-optimizations are great, if you can actually measure them and they
matter :)
If you are looking for someplace to start, might I recommend the
drivers/staging/ directory? I take all sorts of "basic" cleanup
patches, and there are loads of things to do in there. Look at the
drivers/staging/*/TODO files for specific examples of what needs to be
done to get these files cleaned up and fixed properly.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2015-09-16 20:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 19:53 First kernel patch (optimization) Eric Curtin
2015-09-15 20:11 ` Felipe Balbi
2015-09-16 0:09 ` Steve Calfee
2015-09-16 11:45 ` Austin S Hemmelgarn
2015-09-16 12:56 ` David Laight
2015-09-17 1:49 ` Jaime Arrocha
2015-09-17 8:45 ` David Laight
2015-09-16 13:24 ` Greg KH
2015-09-16 16:03 ` Eric Curtin
2015-09-16 16:40 ` Theodore Ts'o
2015-09-16 17:24 ` Raymond Jennings
2015-09-16 17:26 ` Josh Boyer
2015-09-18 3:12 ` Theodore Ts'o
2015-09-18 7:42 ` Greg KH
2015-09-18 9:31 ` Raymond Jennings
2015-09-18 19:08 ` Austin S Hemmelgarn
2015-09-19 2:26 ` Theodore Ts'o
2015-09-19 4:22 ` Sudip Mukherjee
2015-09-19 5:18 ` Greg KH
2015-09-19 12:20 ` Theodore Ts'o
2015-09-19 12:52 ` Alexander Holler
2015-09-19 14:14 ` Alexander Holler
2015-09-19 14:22 ` Theodore Ts'o
2015-09-19 17:47 ` Alexander Holler
2015-09-20 2:21 ` Theodore Ts'o
2015-09-20 10:41 ` Alexander Holler
2015-09-21 15:47 ` Austin S Hemmelgarn
2015-09-21 17:20 ` Alexander Holler
2015-09-21 18:41 ` Alexander Holler
2015-09-23 8:59 ` Alexander Holler
2015-09-28 6:54 ` Thiago Farina
2015-09-28 14:20 ` Greg KH
2015-09-16 20:02 ` Greg KH [this message]
2015-09-16 20:21 ` Eric Curtin
2015-09-16 22:38 ` Greg KH
2015-09-22 17:38 ` Linus Torvalds
2015-09-22 18:18 ` Eric Curtin
2015-09-25 22:06 ` Dmitry Torokhov
2015-09-26 13:28 ` Eric Curtin
2015-09-29 13:51 ` Austin S Hemmelgarn
2015-09-29 14:47 ` Eric Curtin
-- strict thread matches above, loose matches on Subject: below --
2015-09-15 19:52 Eric Curtin
2015-09-15 21:57 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916200210.GA6341@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ahferroin7@gmail.com \
--cc=ericcurtin17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah.kh@samsung.com \
--cc=stevecalfee@gmail.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox