From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754207AbbIPUCP (ORCPT ); Wed, 16 Sep 2015 16:02:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53180 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752955AbbIPUCM (ORCPT ); Wed, 16 Sep 2015 16:02:12 -0400 Date: Wed, 16 Sep 2015 13:02:10 -0700 From: Greg KH To: Eric Curtin Cc: Austin S Hemmelgarn , Steve Calfee , Valentina Manea , shuah.kh@samsung.com, USB list , Kernel development list Subject: Re: First kernel patch (optimization) Message-ID: <20150916200210.GA6341@kroah.com> References: <1442346808-3784-1-git-send-email-ericcurtin17@gmail.com> <55F95671.6060405@gmail.com> <20150916132426.GA7420@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > Hi Greg, > > As I said in the subject of the mail (which I have been since told I > shouldn't have done this), I'm a noob to kernel code. I tried to pick > off something super simple to just see what the process of getting a > patch in is. Youtube videos and documentation only get you so far. > > >From reading your response, should I refrain from sending in these > micro-optimizations in future? Getting in smaller patches is easier > for me as I only do this in my spare time, which I don't have a lot > of! micro-optimizations are great, if you can actually measure them and they matter :) If you are looking for someplace to start, might I recommend the drivers/staging/ directory? I take all sorts of "basic" cleanup patches, and there are loads of things to do in there. Look at the drivers/staging/*/TODO files for specific examples of what needs to be done to get these files cleaned up and fixed properly. Hope this helps, greg k-h