From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753554AbbIPWPU (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Sep 2015 18:15:20 -0400
Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:47863 "EHLO
	ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751830AbbIPWPN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Sep 2015 18:15:13 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2DcEQCA6flVPOV8LHlegyOBPYZZoj8BAQEBAQEGimuRHQQCAoFJTQEBAQEBAQcBAQEBQT+EJAEBBCcTHDMIAw4KCSUPBSUDBxoBEogtyjIsGYYThUSEKhEBWIQsAQSVXo0Ajn+MFoR2LDOIa4E/AQEB
Date: Thu, 17 Sep 2015 08:07:04 +1000
From: Dave Chinner <david@fromorbit.com>
To: Chris Mason <clm@fb.com>, Jan Kara <jack@suse.cz>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Josef Bacik <jbacik@fb.com>, LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Neil Brown <neilb@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()
Message-ID: <20150916220704.GM3902@dastard>
References: <CA+55aFyK3Ua2ZcKLUBvESzxh=pH4x28QeijypJvSPiWbZStV-g@mail.gmail.com>
 <CA+55aFxpd0qrzb_4WamkYekiOXsi5Bs69kK8uj_Xg6MSYs4QtA@mail.gmail.com>
 <20150911231636.GC4150@ret.masoncoding.com>
 <CA+55aFx=HdDMhK0bL8aNxOS83M3EOKGCLY59QzTF-jT+MPHXBw@mail.gmail.com>
 <20150912230027.GE4150@ret.masoncoding.com>
 <20150913231258.GS26895@dastard>
 <CA+55aFxYQ4bfBbyG97W=Yrzf+tpezrvktBBb=DmFX1we2+mdrw@mail.gmail.com>
 <20150916151621.GA8624@ret.masoncoding.com>
 <20150916195806.GD29530@quack.suse.cz>
 <20150916200012.GB8624@ret.masoncoding.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150916200012.GB8624@ret.masoncoding.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 16, 2015 at 04:00:12PM -0400, Chris Mason wrote:
> On Wed, Sep 16, 2015 at 09:58:06PM +0200, Jan Kara wrote:
> > On Wed 16-09-15 11:16:21, Chris Mason wrote:
> > > Short version, Linus' patch still gives bigger IOs and similar perf to
> > > Dave's original.  I should have done the blktrace runs for 60 seconds
> > > instead of 30, I suspect that would even out the average sizes between
> > > the three patches.
> > 
> > Thanks for the data Chris. So I guess we are fine with what's currently in,
> > right?
> 
> Looks like it works well to me.

Graph looks good, though I'll confirm it on my test rig once I get
out from under the pile of email and other stuff that is queued up
after being away for a week...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com