From: Christoph Hellwig <hch@lst.de>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
Christoph Hellwig <hch@lst.de>, "hpa@zytor.com" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Fix gfp flags for coherent DMA memory allocation
Date: Thu, 17 Sep 2015 02:04:42 +0200 [thread overview]
Message-ID: <20150917000442.GA21686@lst.de> (raw)
In-Reply-To: <20150914073834.GA13077@xzibit.linux.bs1.fc.nec.co.jp>
On Mon, Sep 14, 2015 at 07:38:36AM +0000, Junichi Nomura wrote:
> Commit 6894258eda2f reversed the order of gfp_flags adjustment in
> dma_alloc_attrs() for x86 [arch/x86/kernel/pci-dma.c]
> As a result, relevant flags set by dma_alloc_coherent_gfp_flags()
> is just discarded and causes coherent DMA memory allocation failure
> on some devices.
Oops, sorry. Thanks for fixing this:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2015-09-17 0:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 7:38 [PATCH] x86: Fix gfp flags for coherent DMA memory allocation Junichi Nomura
2015-09-15 9:36 ` Junichi Nomura
2015-09-16 21:47 ` Tony Luck
2015-09-17 0:04 ` Christoph Hellwig [this message]
2015-09-17 14:27 ` [tip:x86/urgent] x86/pci/dma: " tip-bot for Junichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917000442.GA21686@lst.de \
--to=hch@lst.de \
--cc=hpa@zytor.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox