From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbbIQAEp (ORCPT ); Wed, 16 Sep 2015 20:04:45 -0400 Received: from verein.lst.de ([213.95.11.211]:38981 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521AbbIQAEo (ORCPT ); Wed, 16 Sep 2015 20:04:44 -0400 Date: Thu, 17 Sep 2015 02:04:42 +0200 From: Christoph Hellwig To: Junichi Nomura Cc: "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , Christoph Hellwig , "hpa@zytor.com" Subject: Re: [PATCH] x86: Fix gfp flags for coherent DMA memory allocation Message-ID: <20150917000442.GA21686@lst.de> References: <20150914073834.GA13077@xzibit.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150914073834.GA13077@xzibit.linux.bs1.fc.nec.co.jp> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2015 at 07:38:36AM +0000, Junichi Nomura wrote: > Commit 6894258eda2f reversed the order of gfp_flags adjustment in > dma_alloc_attrs() for x86 [arch/x86/kernel/pci-dma.c] > As a result, relevant flags set by dma_alloc_coherent_gfp_flags() > is just discarded and causes coherent DMA memory allocation failure > on some devices. Oops, sorry. Thanks for fixing this: Acked-by: Christoph Hellwig