From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753234AbbIQBEo (ORCPT ); Wed, 16 Sep 2015 21:04:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:47580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbbIQBEm (ORCPT ); Wed, 16 Sep 2015 21:04:42 -0400 Date: Thu, 17 Sep 2015 09:04:16 +0800 From: Shawn Guo To: maitysanchayan@gmail.com Cc: stefan@agner.ch, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Message-ID: <20150917010416.GH30746@tiger> References: <20150906043232.GD30746@tiger> <20150907084911.GA6877@Sanchayan-Arch.toradex.int> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150907084911.GA6877@Sanchayan-Arch.toradex.int> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2015 at 02:19:11PM +0530, maitysanchayan@gmail.com wrote: > Hi Shawn, > > On 15-09-06 12:32:32, Shawn Guo wrote: > > On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote: > > > Add iio_hwmon node to expose the temperature channel on Vybrid > > > as hardware monitor device using the iio_hwmon driver. > > > > > > Signed-off-by: Sanchayan Maity > > > --- > > > arch/arm/boot/dts/vfxxx.dtsi | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > > > index 39173bb..0993d66 100644 > > > --- a/arch/arm/boot/dts/vfxxx.dtsi > > > +++ b/arch/arm/boot/dts/vfxxx.dtsi > > > @@ -597,5 +597,10 @@ > > > status = "disabled"; > > > }; > > > }; > > > + > > > + iio_hwmon { > > > > Hyphen rather than underscore should be used in node name. > > As per iio-bindings.txt I did this. It is the same in imx23.dtsi and imx28.dtsi. > > http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/iio-bindings.txt#L85 > http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23.dtsi#L570 > http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx28.dtsi#L1246 Oh, sorry, all these should be caught earlier. > > So should this be changed? Yeah, that would be nice, if the change doesn't break anything. Shawn