From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753285AbbIQB6E (ORCPT ); Wed, 16 Sep 2015 21:58:04 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34688 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbbIQB6C (ORCPT ); Wed, 16 Sep 2015 21:58:02 -0400 Date: Thu, 17 Sep 2015 07:27:56 +0530 From: Viresh Kumar To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-pm@vger.kernel.org Subject: Re: [PATCH] cpufreq: integrator: Fix module autoload for OF platform driver Message-ID: <20150917015756.GQ29943@linux> References: <20150916202446.GA4303@goodgumbo.baconseed.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150916202446.GA4303@goodgumbo.baconseed.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-09-15, 22:24, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > > Hello, > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be found here: > https://lkml.org/lkml/2015/7/30/519 > > Thanks, > Luis > > drivers/cpufreq/integrator-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c > index 2faa421..79e3ff2 100644 > --- a/drivers/cpufreq/integrator-cpufreq.c > +++ b/drivers/cpufreq/integrator-cpufreq.c > @@ -221,6 +221,8 @@ static const struct of_device_id integrator_cpufreq_match[] = { > { }, > }; > > +MODULE_DEVICE_TABLE(of, integrator_cpufreq_match); > + > static struct platform_driver integrator_cpufreq_driver = { > .driver = { > .name = "integrator-cpufreq", Acked-by: Viresh Kumar -- viresh