From: Greg KH <gregkh@linuxfoundation.org>
To: Sakshi Vaid <sakshivaid95@gmail.com>
Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org,
andreas.dilger@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: lustre: lustre: mdc: lproc_mdc.c: declared file_operations struct as const
Date: Wed, 16 Sep 2015 21:25:07 -0700 [thread overview]
Message-ID: <20150917042507.GA16842@kroah.com> (raw)
In-Reply-To: <1442406661-3924-1-git-send-email-sakshivaid95@gmail.com>
On Wed, Sep 16, 2015 at 06:01:01PM +0530, Sakshi Vaid wrote:
> Declared the file_operations structure as const as done elsewhere in the
> kernel, as there are no modifiactions to this field.
>
> Following warning found by checkpatch
> WARNING: struct file_operations should normally be const
>
> Signed-off-by: Sakshi Vaid <sakshivaid95@gmail.com>
> ---
> drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c b/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> index c791941..c62c0ac 100644
> --- a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> +++ b/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> @@ -146,7 +146,7 @@ static ssize_t mdc_kuc_write(struct file *file,
> return count;
> }
>
> -struct file_operations mdc_kuc_fops = {
> +const struct file_operations mdc_kuc_fops = {
> .open = mdc_kuc_open,
> .write = mdc_kuc_write,
> .release = single_release,
This doesn't apply to my tree at all, what are you making it against?
prev parent reply other threads:[~2015-09-17 4:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 12:31 [PATCH] Staging: lustre: lustre: mdc: lproc_mdc.c: declared file_operations struct as const Sakshi Vaid
2015-09-17 4:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917042507.GA16842@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=sakshivaid95@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox