From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbbIQEZM (ORCPT ); Thu, 17 Sep 2015 00:25:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39162 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbbIQEZL (ORCPT ); Thu, 17 Sep 2015 00:25:11 -0400 Date: Wed, 16 Sep 2015 21:25:07 -0700 From: Greg KH To: Sakshi Vaid Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org, andreas.dilger@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: lustre: lustre: mdc: lproc_mdc.c: declared file_operations struct as const Message-ID: <20150917042507.GA16842@kroah.com> References: <1442406661-3924-1-git-send-email-sakshivaid95@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442406661-3924-1-git-send-email-sakshivaid95@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2015 at 06:01:01PM +0530, Sakshi Vaid wrote: > Declared the file_operations structure as const as done elsewhere in the > kernel, as there are no modifiactions to this field. > > Following warning found by checkpatch > WARNING: struct file_operations should normally be const > > Signed-off-by: Sakshi Vaid > --- > drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c b/drivers/staging/lustre/lustre/mdc/lproc_mdc.c > index c791941..c62c0ac 100644 > --- a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c > +++ b/drivers/staging/lustre/lustre/mdc/lproc_mdc.c > @@ -146,7 +146,7 @@ static ssize_t mdc_kuc_write(struct file *file, > return count; > } > > -struct file_operations mdc_kuc_fops = { > +const struct file_operations mdc_kuc_fops = { > .open = mdc_kuc_open, > .write = mdc_kuc_write, > .release = single_release, This doesn't apply to my tree at all, what are you making it against?