From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754590AbbIQIsi (ORCPT ); Thu, 17 Sep 2015 04:48:38 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:24031 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754187AbbIQIse (ORCPT ); Thu, 17 Sep 2015 04:48:34 -0400 Date: Thu, 17 Sep 2015 16:44:24 +0800 From: Jisheng Zhang To: , , , , CC: , Subject: Re: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle Message-ID: <20150917164424.513801a6@xhacker> In-Reply-To: <20150917160744.52400e0e@xhacker> References: <1442424760-4104-1-git-send-email-jszhang@marvell.com> <20150917160744.52400e0e@xhacker> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-09-17_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1509170158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Steven, On Thu, 17 Sep 2015 16:07:44 +0800 Jisheng Zhang wrote: > Dear all, > > On Thu, 17 Sep 2015 01:32:40 +0800 > Jisheng Zhang wrote: > > > Currently, if cpuidle is disabled or not supported, powertop reports > > zero wakeups and zero events. This is due to the cpu_idle tracepoints > > are missing. > > > > This patch is to make cpu_idle tracepoints always available even if > > cpuidle is disabled or not supported. > > > > Signed-off-by: Jisheng Zhang > > --- > > Since v1: > > - ignore arm_pm_idle. > > Something related: let's have a look at arch/arm/mach-omap2/pm34xx.c > the omap3_pm_idle(void) function, it uses trace_cpu_idle(), should we > use the _rcuidle version as below: 484546509ce5 ("x86/tracing: Denote the power and cpuidle tracepoints as _rcuidle()") make me think we need to fix omap3_pm_idle, right? Thanks, Jisheng > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c > index 87b98bf9..b3bc972 100644 > --- a/arch/arm/mach-omap2/pm34xx.c > +++ b/arch/arm/mach-omap2/pm34xx.c > @@ -301,11 +301,11 @@ static void omap3_pm_idle(void) > if (omap_irq_pending()) > return; > > - trace_cpu_idle(1, smp_processor_id()); > + trace_cpu_rcuidle(1, smp_processor_id()); > > omap_sram_idle(); > > - trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id()); > + trace_cpu_rcuidle(PWR_EVENT_EXIT, smp_processor_id()); > } > > #ifdef CONFIG_SUSPEND > > > > > arch/arm/kernel/process.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c > > index 7a7c4ce..83d2dc5 100644 > > --- a/arch/arm/kernel/process.c > > +++ b/arch/arm/kernel/process.c > > @@ -28,6 +28,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -66,11 +67,15 @@ void (*arm_pm_idle)(void); > > > > void arch_cpu_idle(void) > > { > > - if (arm_pm_idle) > > + if (arm_pm_idle) { > > arm_pm_idle(); > > - else > > + local_irq_enable(); > > + } else { > > + trace_cpu_idle_rcuidle(1, smp_processor_id()); > > cpu_do_idle(); > > - local_irq_enable(); > > + local_irq_enable(); > > + trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id()); > > + } > > } > > > > void arch_cpu_idle_prepare(void) > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel