From: Ingo Molnar <mingo@kernel.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@amacapital.net>,
Kees Cook <keescook@chromium.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/2] x86/math-emu: Remove define layer for undocumented opcodes
Date: Fri, 18 Sep 2015 09:36:15 +0200 [thread overview]
Message-ID: <20150918073615.GB2691@gmail.com> (raw)
In-Reply-To: <1442432914-27022-2-git-send-email-dvlasenk@redhat.com>
* Denys Vlasenko <dvlasenk@redhat.com> wrote:
> No code changes.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Ingo Molnar <mingo@kernel.org>
> CC: Borislav Petkov <bp@alien8.de>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> CC: Andy Lutomirski <luto@amacapital.net>
> CC: Kees Cook <keescook@chromium.org>
> CC: x86@kernel.org
> CC: linux-kernel@vger.kernel.org
> ---
> arch/x86/math-emu/fpu_entry.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)
This patch should come before riskier patches introducing new instructions, to
make eventual reverts and fixes easier.
The rule is generally: sort patches by risk, low risk first, high risk later. This
means that cleanups, restructuring, refactoring patches always come first - beyond
making bisection and reverts easier, those make subsequent patches cleaner as well
and make any bugs in subsequent patches easier to see as well.
Thanks,
Ingo
next prev parent reply other threads:[~2015-09-18 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 19:48 [PATCH 1/2] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns Denys Vlasenko
2015-09-16 19:48 ` [PATCH 2/2] x86/math-emu: Remove define layer for undocumented opcodes Denys Vlasenko
2015-09-18 7:36 ` Ingo Molnar [this message]
2015-09-16 19:51 ` [PATCH 1/2] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns Denys Vlasenko
2015-09-17 7:22 ` Ingo Molnar
2015-09-18 7:33 ` Ingo Molnar
2015-09-18 14:53 ` Denys Vlasenko
2015-09-20 8:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918073615.GB2691@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox