From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbbIRHgV (ORCPT ); Fri, 18 Sep 2015 03:36:21 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:34117 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbbIRHgT (ORCPT ); Fri, 18 Sep 2015 03:36:19 -0400 Date: Fri, 18 Sep 2015 09:36:15 +0200 From: Ingo Molnar To: Denys Vlasenko Cc: Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH 2/2] x86/math-emu: Remove define layer for undocumented opcodes Message-ID: <20150918073615.GB2691@gmail.com> References: <1442432914-27022-1-git-send-email-dvlasenk@redhat.com> <1442432914-27022-2-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442432914-27022-2-git-send-email-dvlasenk@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Denys Vlasenko wrote: > No code changes. > > Signed-off-by: Denys Vlasenko > CC: Ingo Molnar > CC: Borislav Petkov > CC: "H. Peter Anvin" > CC: Andy Lutomirski > CC: Kees Cook > CC: x86@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/math-emu/fpu_entry.c | 29 +++++++++-------------------- > 1 file changed, 9 insertions(+), 20 deletions(-) This patch should come before riskier patches introducing new instructions, to make eventual reverts and fixes easier. The rule is generally: sort patches by risk, low risk first, high risk later. This means that cleanups, restructuring, refactoring patches always come first - beyond making bisection and reverts easier, those make subsequent patches cleaner as well and make any bugs in subsequent patches easier to see as well. Thanks, Ingo