public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Yassin Jaffer <yassinjaffer@gmail.com>
Cc: "linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] input: Add new sun4i-keypad driver
Date: Fri, 18 Sep 2015 11:44:31 +0200	[thread overview]
Message-ID: <20150918094431.GN4684@lukather> (raw)
In-Reply-To: <CAJzetvvUscEgTQ0Sr-BF7D6rzN_bfWT1KikRqz+BvSV-2+TWrw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Hi Yassin,

On Fri, Sep 18, 2015 at 10:19:55AM +1000, Yassin Jaffer wrote:
> Hi Maxime
> 
> I appreciate your time and efforts .
> 
> Do you need that rate to be enforced, or is it some leftover from the
> > allwinner BSP?
> 
> 
> I've found that clock rate works fine with the default denounce and scan
> cycle.

It was not really my point. My point was do you *need* it to operate.

And so your properties were in clock cycles?

Please use a unit indenpendant of the clock rate, like seconds or Hz
(or any multiple of them).

> By the way do you have any dev board which expose the keypad pins?

I don't think I have any.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-09-18  9:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15 14:05 NEW SUN4i KEYPAD DRIVER yassinjaffer
2015-09-15 14:05 ` [PATCH 1/4] ARM:dts:sun7i: Add keypad clk node yassinjaffer
2015-09-16  5:11   ` Maxime Ripard
2015-09-15 14:05 ` [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC yassinjaffer
2015-09-17 11:29   ` Maxime Ripard
2015-09-17 14:20     ` [linux-sunxi] " Chen-Yu Tsai
2015-09-15 14:05 ` [PATCH 3/4] input: Add new sun4i-keypad driver yassinjaffer
2015-09-17 13:05   ` Maxime Ripard
     [not found]     ` <CAJzetvvUscEgTQ0Sr-BF7D6rzN_bfWT1KikRqz+BvSV-2+TWrw@mail.gmail.com>
2015-09-18  9:44       ` Maxime Ripard [this message]
2015-09-21 17:19   ` Dmitry Torokhov
2015-09-15 14:05 ` [PATCH 4/4] devicetree: bindings:Allwinner sun4i keypad yassinjaffer
2015-09-15 15:30   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150918094431.GN4684@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=yassinjaffer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox