public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Kohji Okuno <okuno.kohji@jp.panasonic.com>
Cc: <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting
Date: Fri, 18 Sep 2015 11:03:12 +0100	[thread overview]
Message-ID: <20150918110312.0a49d22d@arm.com> (raw)
In-Reply-To: <20150918.182207.856288392397747867.okuno.kohji@jp.panasonic.com>

On Fri, 18 Sep 2015 18:22:07 +0900
Kohji Okuno <okuno.kohji@jp.panasonic.com> wrote:

> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Fri, 18 Sep 2015 11:04:23 +0200
> > That's weird. The flow is:
> > 
> > interrupt()
> >   mask()
> >   ret = primary_handler()
> >   if (ret == WAKE_THREAD)
> >     wake_thread()
> >   else
> >     unmask()
> > 
> > thread_handler()
> >   ....
> >   unmask()
> > 
> > So if an interrupt is triggered on the device while the interrupt is
> > masked it should be raised again immediately when the unmask happens
> > because its level type.
> > 
> > I'm wondering why that doesn't work.
> 
> Yes. I think so. And, I have just found that sdhci_thread_irq() don't
> finish in this case. I'm analyzing about this now. But, after I apply
> my patch, sdhci_thread_irq() can finish. I will share the result with
> you.

What do you mean exactly by "don't finish"? Does it hang somewhere? Or
keeps processing data but never drains?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.

  reply	other threads:[~2015-09-18 10:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  7:13 [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting Kohji Okuno
2015-09-17  7:59 ` Thomas Gleixner
2015-09-17  8:21   ` Kohji Okuno
2015-09-17  9:48     ` Kohji Okuno
2015-09-17 21:10       ` Thomas Gleixner
2015-09-18  0:35         ` Kohji Okuno
2015-09-18  9:04           ` Thomas Gleixner
2015-09-18  9:22             ` Kohji Okuno
2015-09-18 10:03               ` Marc Zyngier [this message]
2015-09-18 10:56                 ` Kohji Okuno
2015-09-18 14:46                   ` Thomas Gleixner
2015-09-19 15:33                     ` Kohji Okuno
2015-09-19 20:24                       ` Thomas Gleixner
2015-09-20  0:21                         ` Kohji Okuno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150918110312.0a49d22d@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okuno.kohji@jp.panasonic.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox