From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753560AbbIRMDb (ORCPT ); Fri, 18 Sep 2015 08:03:31 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:33238 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbbIRMDa (ORCPT ); Fri, 18 Sep 2015 08:03:30 -0400 Date: Fri, 18 Sep 2015 12:39:41 +0100 From: Charles Keepax To: Sudip Mukherjee CC: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH 2/3] ASoC: wm0010: fix memory leak Message-ID: <20150918113941.GG7694@ck-lbox> References: <1442572341-28201-1-git-send-email-sudipm.mukherjee@gmail.com> <1442572341-28201-2-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1442572341-28201-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-09-18_05:2015-09-18,2015-09-18,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1508030000 definitions=main-1509180167 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 04:02:20PM +0530, Sudip Mukherjee wrote: > We have requested for the firmware but we have missed releasing it both > on success and on error path. > While checking the code it turned out that the requested firmware is not > even used. More over the same firmware is being loaded by > wm0010_stage2_load(). > > Signed-off-by: Sudip Mukherjee > --- hmm... odd guess this must have been missed when wm0010_stage2_load was created. Acked-by: Charles Keepax Thanks, Charles