From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754510AbbIRPhF (ORCPT ); Fri, 18 Sep 2015 11:37:05 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33222 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753705AbbIRPhD (ORCPT ); Fri, 18 Sep 2015 11:37:03 -0400 Date: Fri, 18 Sep 2015 17:36:57 +0200 From: Thierry Reding To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, Terje =?utf-8?Q?Bergstr=C3=B6m?= , David Airlie , Stephen Warren , Alexandre Courbot , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 5/5] drm/tegra: Fix module autoload for OF platform driver Message-ID: <20150918153657.GA6692@ulmo.nvidia.com> References: <20150917142232.GA20243@goodgumbo.baconseed.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW" Content-Disposition: inline In-Reply-To: <20150917142232.GA20243@goodgumbo.baconseed.org> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 17, 2015 at 04:22:32PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. >=20 > Signed-off-by: Luis de Bethencourt > --- > drivers/gpu/drm/tegra/drm.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c > index 2486bc2..62d724d 100644 > --- a/drivers/gpu/drm/tegra/drm.c > +++ b/drivers/gpu/drm/tegra/drm.c > @@ -1064,6 +1064,7 @@ static const struct of_device_id host1x_drm_subdevs= [] =3D { > { .compatible =3D "nvidia,tegra210-sor1", }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, host1x_drm_subdevs); This shouldn't be necessary because the MODULE_DEVICE_TABLE entries are already in the subdrivers. Thierry --0F1p//8PRICkK4MW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJV/C+VAAoJEN0jrNd/PrOhJ40P/1Oec3+CJS3qmmnpnjZvn/CI O29M65FCOAk5ZyHXq8up5QWg6mgfaFp6zzHyWWAJJ7bpJbf+BSgUWnZQPuxNsRoQ NmB7zZP8vYllmE3W8pGFlUd2iMenzcV2ctQmX+ljKSFVDNIT3XF7lq5crUaAP6B9 GyE9FsOTAF/e8SjUOcdlANdo6TJGWqht94cs4DJEvt3FzmKD/UjEqlcOse5kNoas ofbvQPOMiVM+vR4+0wl/N93T2wdIRulF5BsokvrIqXXoabq1JwJYg//3OpJeXbvm ONESlDxm76KIbkcZYxVeBwKId6cfSwXPT3sXgBJKNUvO6LZ650+1yGHtBBnPg4br nCAY6IxBZrB3SlEERvIucTWkgeTwFhsP/r4F9642dBTR9LYHdYyxJkEZmngaNvJv 2RMhHkscx2D5iDc6BXzrwn+DwbEXVGB9zNLmQSRl9c7myueashhrELmd4FWZIZMc GxS1wnfBv3yMyg1WoeKAbCys6D0L9hKSVU20Dt0C7+BC/e9hEeuouWxLJWIJ8deL HzodAj92xf/V+tfYRm+82egNNmD7vFQnt4b6I0M0Ifeye/FpI8lEbUowTC6NPWe1 s2oCpziX83gXW9NemuHkHaU+LyGs5lNhnIN3xWqPVuhE3nbI7n2yKbZC5HGmp+OD iaEibL6O4+vNAmTdXlhA =QJPK -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW--