From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbbIRQHr (ORCPT ); Fri, 18 Sep 2015 12:07:47 -0400 Received: from casper.infradead.org ([85.118.1.10]:45290 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbbIRQHq (ORCPT ); Fri, 18 Sep 2015 12:07:46 -0400 Date: Fri, 18 Sep 2015 18:02:21 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: Jens Axboe , Ingo Molnar , Frederic Weisbecker , Chris Mason , Dave Chinner , Jan Kara , Josef Bacik , LKML , linux-fsdevel , Neil Brown , Christoph Hellwig , Tejun Heo Subject: Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug() Message-ID: <20150918160221.GF11639@twins.programming.kicks-ass.net> References: <20150917235647.GG8624@ret.masoncoding.com> <20150918003735.GR3902@dastard> <20150918054044.GT3902@dastard> <20150918131615.GI8624@ret.masoncoding.com> <55FC1E72.3040500@fb.com> <20150918155956.GZ3816@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150918155956.GZ3816@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 05:59:56PM +0200, Peter Zijlstra wrote: > > - if it's not an actual PREEMPT_ACTIVE (ie in a random place) > > PREEMPT_ACTIVE is actually a recursion flag, 'random place' does not > factor into it. That is, most 'random places' will not have > PREEMPT_ACTIVE set. Ah, _not_ PREEMPT_ACTIVE, its late and I can't read no moar.