From: Felipe Balbi <balbi@ti.com>
To: <eu@felipetonello.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Peter Chen <Peter.Chen@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Subject: Re: [PATCH] usb: chipidea: udc: improve error handling on ep_queue and f_midi
Date: Fri, 18 Sep 2015 12:01:06 -0500 [thread overview]
Message-ID: <20150918170106.GA7636@saruman.tx.rr.com> (raw)
In-Reply-To: <1442594925-31131-1-git-send-email-eu@felipetonello.com>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
Hi,
On Fri, Sep 18, 2015 at 05:48:45PM +0100, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> _ep_queue() didn't check for errors when using add_td_to_list()
> which can fail if dma_pool_alloc fails, thus causing a kernel
> panic when lastnode->ptr is NULL.
>
> Also f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
> drivers/usb/chipidea/udc.c | 26 +++++++++++++++++++-------
> drivers/usb/gadget/function/f_midi.c | 11 +++++++++--
why are you patching f_midi.c in a chipidea patch ? Have a read at
Documentation/SubmittingPatches, Documentation/SubmitChecklist
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-09-18 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 16:48 [PATCH] usb: chipidea: udc: improve error handling on ep_queue and f_midi eu
2015-09-18 17:01 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918170106.GA7636@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=Peter.Chen@freescale.com \
--cc=andrzej.p@samsung.com \
--cc=eu@felipetonello.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox