From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450AbbIRTdR (ORCPT ); Fri, 18 Sep 2015 15:33:17 -0400 Received: from down.free-electrons.com ([37.187.137.238]:34409 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751874AbbIRTdQ (ORCPT ); Fri, 18 Sep 2015 15:33:16 -0400 Date: Fri, 18 Sep 2015 21:33:13 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Hans de Goede , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [linux-sunxi] [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33 Message-ID: <20150918193313.GU4684@lukather> References: <1442561739-6824-1-git-send-email-wens@csie.org> <1442561739-6824-3-git-send-email-wens@csie.org> <55FC2E31.3060007@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="R4RAxL8G0iuuxuj8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --R4RAxL8G0iuuxuj8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 19, 2015 at 12:18:04AM +0800, Chen-Yu Tsai wrote: > On Fri, Sep 18, 2015 at 11:30 PM, Hans de Goede wro= te: > > Hi, > > > > On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: > >> > >> The PWM controller has 2 outputs, with one usable pin for each. > >> > >> Add a pinmux setting for the first channel. This is often used > >> for backlight dimming on tablets. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi > >> b/arch/arm/boot/dts/sun8i-a23-a33.dtsi > >> index e7054304018a..8f4db82084c5 100644 > >> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi > >> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi > >> @@ -412,6 +412,13 @@ > >> allwinner,pull =3D ; > >> }; > >> > >> + pwm0_pins: pwm0 { > > > > > > This should be "pwm0_pins_a: pwm0@0" so as to be consistent with the a1= 0 / > > a20 dtsi > > files. >=20 > This is the only possible setting. I do not see why we need "_a" for the > label and "@0" for the name. IMHO they are used to avoid name clashes when > there are multiple possible pinmux settings. Yep, sounds reasonable, I applied the patch. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --R4RAxL8G0iuuxuj8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV/Gb5AAoJEBx+YmzsjxAg6BIP/j1dY01bgev0Ia8VE6N0WJfo zaUW7gTQ1D+X04vIF/J4f+JRlk+tUKaKGzYG05Rmp2FqCAUFnM4ApGO2LLyEzT+e JP97kApWxnB3NwubOEIY4ny9bxvIHBYtojTTZ4Nq7TYDNj126nfnifrQHOihJKEZ e18kU6ZYdMZMrJeTHLnnMvkFWNnVcOgTtd+9gdD17jNdJ4Fc7+W/cV0aCeWFZfrD Npu2M7KJV4MeyukBpyJbhoFCePkap5ErJH4ogpVBRCPi1m5FW0/JpJTKrI75tMbi ggRDOej+RhkW5mf5BR95bJ/Mk2JBDYHL8Mn9ipmOQR9jaVQLPgHnV/O3TrmW3k9u DBmzOFdXKrr5Eed/lgBYxvH1nUW+OOaH3Gax6nOw8XR9lyTuCI+joGjW6VVb/Yfg 11KTJa/Qvem2CwFnON6jOVk1810cHo8H9Z/KH/lLWJyvD9k7jHXRgUiHNpsc2rZx fC45Ajvbexp8sOrAMrnJdpIYIaIB5qpwKsg0hlj0DAyNW4gIhTzX2HEzR7QX4hbl 9e0lPC0kLlwCZiJz0K60phVVeuU9f9NxjmmRLIrfgrCTcp6Bcgbxhg5hcVxmPsZT auFm/Lm70A43oBV9kFK61qhrxH5+8V/+8pTgVWhMBFFLrl0ST6Mx5sXZELWGet+B dQ6fc/dQ53rROi2C34kf =TFag -----END PGP SIGNATURE----- --R4RAxL8G0iuuxuj8--