From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbbIRTir (ORCPT ); Fri, 18 Sep 2015 15:38:47 -0400 Received: from mail.kernel.org ([198.145.29.136]:46272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752618AbbIRTiq (ORCPT ); Fri, 18 Sep 2015 15:38:46 -0400 Date: Fri, 18 Sep 2015 16:38:42 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Ingo Molnar , Namhyung Kim , Adrian Hunter , David Ahern , Wang Nan , Linux Kernel Mailing List Subject: Re: tools build: Unused function, incomplete rename Message-ID: <20150918193842.GX11551@kernel.org> References: <20150918192334.GW11551@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150918192334.GW11551@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Sep 18, 2015 at 04:23:34PM -0300, Arnaldo Carvalho de Melo escreveu: > Hi Jiri, Ingo, > > While trying to figure out why the bpf feature test is always > triggering the display of the "Auto-detecting system features" I noticed > this pattern: Another problem, this time in how tools/lib/bpf/ specifies which features to test for and which ones should have the feature detection shown, does the following patch makes sense? I think it does because FEATURE_TESTS looks like the ones that will be tested, and FEATURE_DISPLAY the ones that will appear...: diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index f68d23a0b487..604c12081b4b 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -64,8 +64,8 @@ srctree := $(patsubst %/,%,$(dir $(srctree))) #$(info Determined 'srctree' to be $(srctree)) endif -FEATURE_DISPLAY = libelf libelf-getphdrnum libelf-mmap bpf -FEATURE_TESTS = libelf bpf +FEATURE_TESTS = libelf libelf-getphdrnum libelf-mmap bpf +FEATURE_DISPLAY = libelf bpf INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/arch/$(ARCH)/include/uapi -I$(srctree)/include/uapi FEATURE_CHECK_CFLAGS-bpf = $(INCLUDES)