From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752639AbbIRUuB (ORCPT ); Fri, 18 Sep 2015 16:50:01 -0400 Received: from mail.kernel.org ([198.145.29.136]:48927 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659AbbIRUuA (ORCPT ); Fri, 18 Sep 2015 16:50:00 -0400 Date: Fri, 18 Sep 2015 17:49:55 -0300 From: Arnaldo Carvalho de Melo To: Mathieu Poirier Cc: a.p.zijlstra@chello.nl, Ingo Molnar , linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, Adrian Hunter Subject: Re: [PATCH] perf record: adding dummy event before mapping Message-ID: <20150918204955.GA11551@kernel.org> References: <1442608924-28139-1-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442608924-28139-1-git-send-email-mathieu.poirier@linaro.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Sep 18, 2015 at 02:42:04PM -0600, Mathieu Poirier escreveu: > The parameters of function 'perf_evsel__open()' in > 'record_open()' have been changed to use the evsel's cpus and > threads rather than the evlist since: > > commit d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads") > > This works fine for as long as all the events have been added to > the evlist before function 'perf_evlist__create_maps()' is called > since the latter will take care of pushing the cpus and threads of > the evlist to each of the evsel in the list. > > As function 'auxtrace_record__options()' adds a "dummy:u" event to > the evlist it is important that it runs before > 'perf_evlist__create_maps()'. What tree is this patch for? Please take a look at tip/master, there are patches there that should address this issue, please report if not. Namely, hey, it was already merged by Linus, see: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/tools There is a set of very small patches by Adrian Hunter fixing the setting of evsel->{cpus,threads} Can you check with Linus's git repo? I bet you tried with 4.3-rc1? - Arnaldo > Signed-off-by: Mathieu Poirier > --- > tools/perf/builtin-record.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 142eeb341b29..630a7a8e3970 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -1183,14 +1183,14 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused) > goto out_symbol_exit; > } > > - err = -ENOMEM; > - if (perf_evlist__create_maps(rec->evlist, &rec->opts.target) < 0) > - usage_with_options(record_usage, record_options); > - > err = auxtrace_record__options(rec->itr, rec->evlist, &rec->opts); > if (err) > goto out_symbol_exit; > > + err = -ENOMEM; > + if (perf_evlist__create_maps(rec->evlist, &rec->opts.target) < 0) > + usage_with_options(record_usage, record_options); > + > if (record_opts__config(&rec->opts)) { > err = -EINVAL; > goto out_symbol_exit; > -- > 1.9.1