From: Darren Hart <dvhart@infradead.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] toshiba_acpi: Remove unneeded u32 variables from *setup_keyboard
Date: Fri, 18 Sep 2015 14:48:32 -0700 [thread overview]
Message-ID: <20150918214832.GK66179@vmdeb7> (raw)
In-Reply-To: <1441819810-11762-1-git-send-email-coproscefalo@gmail.com>
On Wed, Sep 09, 2015 at 11:30:08AM -0600, Azael Avalos wrote:
> The function toshiba_acpi_setup_keyboard currently has two u32 variables
> used to store the Hotkey Event Type and the result of the HCI_SYSTEM_EVENT
> query.
>
> This patch removes those two variables, as we already have a global
> variable named "hotkey_event_type" and the result of the HCI_SYSTEM_EVENT
> query can be checked directly from the function.
>
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
...
> goto err_free_dev;
> @@ -2443,12 +2440,10 @@ static int toshiba_acpi_setup_keyboard(struct toshiba_acpi_dev *dev)
> * Determine hotkey query interface. Prefer using the INFO
> * method when it is available.
> */
> - if (acpi_has_method(dev->acpi_dev->handle, "INFO"))
> + if (acpi_has_method(dev->acpi_dev->handle, "INFO")) {
> dev->info_supported = 1;
> - else {
> - hci_result = hci_write(dev, HCI_SYSTEM_EVENT, 1);
> - if (hci_result == TOS_SUCCESS)
> - dev->system_event_supported = 1;
> + } else if (hci_write(dev, HCI_SYSTEM_EVENT, 1) == TOS_SUCCESS)
Ahem.
Missing the brace at the end and wreaking havoc on the poor compiler!
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-09-18 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 17:30 [PATCH 1/1] toshiba_acpi: Remove unneeded u32 variables from *setup_keyboard Azael Avalos
2015-09-09 17:30 ` [PATCH 1/1] toshiba_acpi: Add 0x prefix to available_kbd_modes_show funtion Azael Avalos
2015-09-18 21:53 ` Darren Hart
2015-09-09 17:30 ` [PATCH] platform/x86: Toshiba WMI Hotkey Driver Azael Avalos
2015-09-18 21:59 ` Darren Hart
2015-09-19 4:21 ` Azael Avalos
2015-09-19 16:48 ` Dmitry Torokhov
2015-09-22 16:08 ` Azael Avalos
2015-09-18 21:48 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918214832.GK66179@vmdeb7 \
--to=dvhart@infradead.org \
--cc=coproscefalo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox