From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Ivan Grimaldi <grimaldi.ivan@gmail.com>
Cc: a.zummo@towertech.it, mpfj@mimc.co.uk,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH v3 1/2] Fixed ds1390_get_reg returned value
Date: Sat, 19 Sep 2015 00:01:48 +0200 [thread overview]
Message-ID: <20150918220148.GH4287@piout.net> (raw)
In-Reply-To: <1442590077-29816-1-git-send-email-grimaldi.ivan@gmail.com>
Hi,
You've sent that series so many times that I'm not sure which one I
should look at...
Also, please include a changelog when submitting a new version of a
patch.
On 18/09/2015 at 17:27:56 +0200, Ivan Grimaldi wrote :
> spi_write_then_read puts in rx_buf the received data starting from
> the first byte of the rx_buf
>
> Signed-off-by: Ivan Grimaldi <grimaldi.ivan@gmail.com>
> ---
> drivers/rtc/rtc-ds1390.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
> index e67bfcb..a4303b4 100644
> --- a/drivers/rtc/rtc-ds1390.c
> +++ b/drivers/rtc/rtc-ds1390.c
> @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned char address,
> if (status != 0)
> return status;
>
> - *data = chip->txrx_buf[1];
> + *data = chip->txrx_buf[0];
>
> return 0;
> }
> --
> 2.5.2
>
> --
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
> ---
> You received this message because you are subscribed to the Google Groups "rtc-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-09-18 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 15:27 [PATCH v3 1/2] Fixed ds1390_get_reg returned value Ivan Grimaldi
2015-09-18 15:27 ` [PATCH v3 2/2] Added trickle charger device tree binding Ivan Grimaldi
2015-09-18 22:01 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918220148.GH4287@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=grimaldi.ivan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpfj@mimc.co.uk \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox