From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722AbbIRWBv (ORCPT ); Fri, 18 Sep 2015 18:01:51 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35752 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753742AbbIRWBu (ORCPT ); Fri, 18 Sep 2015 18:01:50 -0400 Date: Sat, 19 Sep 2015 00:01:48 +0200 From: Alexandre Belloni To: Ivan Grimaldi Cc: a.zummo@towertech.it, mpfj@mimc.co.uk, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [rtc-linux] [PATCH v3 1/2] Fixed ds1390_get_reg returned value Message-ID: <20150918220148.GH4287@piout.net> References: <1442590077-29816-1-git-send-email-grimaldi.ivan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442590077-29816-1-git-send-email-grimaldi.ivan@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, You've sent that series so many times that I'm not sure which one I should look at... Also, please include a changelog when submitting a new version of a patch. On 18/09/2015 at 17:27:56 +0200, Ivan Grimaldi wrote : > spi_write_then_read puts in rx_buf the received data starting from > the first byte of the rx_buf > > Signed-off-by: Ivan Grimaldi > --- > drivers/rtc/rtc-ds1390.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c > index e67bfcb..a4303b4 100644 > --- a/drivers/rtc/rtc-ds1390.c > +++ b/drivers/rtc/rtc-ds1390.c > @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned char address, > if (status != 0) > return status; > > - *data = chip->txrx_buf[1]; > + *data = chip->txrx_buf[0]; > > return 0; > } > -- > 2.5.2 > > -- > -- > You received this message because you are subscribed to "rtc-linux". > Membership options at http://groups.google.com/group/rtc-linux . > Please read http://groups.google.com/group/rtc-linux/web/checklist > before submitting a driver. > --- > You received this message because you are subscribed to the Google Groups "rtc-linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com