From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753908AbbIRUG6 (ORCPT ); Fri, 18 Sep 2015 16:06:58 -0400 Received: from smtp-1b.atlantis.sk ([80.94.52.26]:44545 "EHLO smtp-1b.atlantis.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752618AbbIRUG4 (ORCPT ); Fri, 18 Sep 2015 16:06:56 -0400 From: Ondrej Zary To: Dan Williams Subject: Re: [PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM Date: Fri, 18 Sep 2015 22:06:41 +0200 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: netdev@vger.kernel.org, Kernel development list References: <1442330289-2907-1-git-send-email-linux@rainbow-software.org> <1442595275.14759.1.camel@redhat.com> In-Reply-To: <1442595275.14759.1.camel@redhat.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201509182206.41988.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 18 September 2015 18:54:35 Dan Williams wrote: > On Tue, 2015-09-15 at 17:18 +0200, Ondrej Zary wrote: > > IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as > > wpa_supplicant uses it for both no encryption and WEP open system. > > Cache the last mode set (only of these two) and use it here. > > > > This allows wpa_supplicant to work with unencrypted APs. > > It seems like this will work; but to make the code clearer, define a > small static function like: > > static inline void set_auth_type(struct airo_info *local, int auth_type) > { > local->config.authType = local->last_auth = auth_type; > } > > and call that from everywhere that you're currently setting authType and > last_auth, except for airo_set_auth(). Less code and less probability > to forget to set last_auth in the future. Good idea, thanks. BTW. What about WPA? Found some old patches adding WPA support to the airo driver. Something on your web: http://people.redhat.com/dcbw/airo-wpa/ and a "recent" (4 years) version at http://svn.gna.org/viewcvs/airo-wpa/branches/kernel/ It looks ugly (wpa_enabled module parameter) but seems to work with WPA-PSK. Do you remember what's the problem with switching between WPA and WEP? I'm going to remove the wpa_enabled module parameter and allow run-time switching between WPA and WEP to see what breaks. -- Ondrej Zary