From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754522AbbIRWlZ (ORCPT ); Fri, 18 Sep 2015 18:41:25 -0400 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:38820 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509AbbIRWlY (ORCPT ); Fri, 18 Sep 2015 18:41:24 -0400 From: "Sinclair Yeh" Date: Fri, 18 Sep 2015 15:42:14 -0700 To: Christian Engelmayer Cc: airlied@linux.ie, thellstrom@vmware.com, brianp@vmware.com, charmainel@vmware.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/vmwgfx: Fix uninitialized return in vmw_cotable_unbind() Message-ID: <20150918224214.GA18173@syeh-linux> References: <1442615470-22149-1-git-send-email-cengelma@gmx.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442615470-22149-1-git-send-email-cengelma@gmx.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Good catch! Reviewed-by: Sinclair Yeh On Sat, Sep 19, 2015 at 12:31:10AM +0200, Christian Engelmayer wrote: > Function vmw_cotable_unbind() uses the uninitialized variable ret as > return value. Make the result deterministic and directly return as > the variable is unused anyway. Detected by Coverity CID 1324256. > > Signed-off-by: Christian Engelmayer > --- > Compile tested only. Applies against linux-next. > --- > drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > index ce659a125f2b..092ea81eeff7 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > @@ -311,7 +311,6 @@ static int vmw_cotable_unbind(struct vmw_resource *res, > struct vmw_private *dev_priv = res->dev_priv; > struct ttm_buffer_object *bo = val_buf->bo; > struct vmw_fence_obj *fence; > - int ret; > > if (list_empty(&res->mob_head)) > return 0; > @@ -328,7 +327,7 @@ static int vmw_cotable_unbind(struct vmw_resource *res, > if (likely(fence != NULL)) > vmw_fence_obj_unreference(&fence); > > - return ret; > + return 0; > } > > /** > -- > 1.9.1 >