* [PATCH] Staging: android: Fix 80 character length
@ 2015-09-18 8:54 Punit Vara
2015-09-19 2:40 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Punit Vara @ 2015-09-18 8:54 UTC (permalink / raw)
To: gregkh; +Cc: arve, riandrews, devel, linux-kernel, Punit Vara
This patch is to the Kconfig file which fixes up lines which
exceeded the standard 80 character limitation.
This file also fixes up 3 warnings regarding paragraph.
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/staging/android/Kconfig | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 42b1512..f4a2371 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -12,7 +12,8 @@ config ASHMEM
file-based API.
It is, in theory, a good memory allocator for low-memory devices,
- because it can discard shared memory units when under memory pressure.
+ because it can discard shared memory units when under memory
+ pressure.
config ANDROID_TIMED_OUTPUT
bool "Timed output class driver"
@@ -24,19 +25,20 @@ config ANDROID_TIMED_GPIO
depends on ANDROID_TIMED_OUTPUT
default n
---help---
- Unlike generic gpio is to allow programs to access and manipulate gpio
- registers from user space, timed output/gpio is a system to allow changing
- a gpio pin and restore it automatically after a specified timeout.
+ Unlike generic gpio is to allow programs to access and manipulate
+ gpio registers from user space, timed output/gpio is a system to
+ allow changing a gpio pin and restore it automatically after a
+ specified timeout.
config ANDROID_LOW_MEMORY_KILLER
bool "Android Low Memory Killer"
---help---
- Registers processes to be killed when low memory conditions, this is useful
- as there is no particular swap space on android.
+ Registers processes to be killed when low memory conditions, this
+ is useful as there is no particular swap space on android.
- The registered process will kills according to the priorities in android init
- scripts (/init.rc), and it defines priority values with minimum free memory size
- for each priority.
+ The registered process will kills according to the priorities in
+ android init scripts (/init.rc), and it defines priority values with
+ minimum free memory size for each priority.
config SYNC
bool "Synchronization framework"
@@ -44,8 +46,9 @@ config SYNC
select ANON_INODES
select DMA_SHARED_BUFFER
---help---
- This option enables the framework for synchronization between multiple
- drivers. Sync implementations can take advantage of hardware
+ This option enables the framework for synchronization between
+ multiple drivers.
+ Sync implementations can take advantage of hardware
synchronization built into devices like GPUs.
config SW_SYNC
@@ -54,7 +57,8 @@ config SW_SYNC
depends on SYNC
---help---
A sync object driver that uses a 32bit counter to coordinate
- synchronization. Useful when there is no hardware primitive backing
+ synchronization.
+ Useful when there is no hardware primitive backing
the synchronization.
config SW_SYNC_USER
--
2.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: android: Fix 80 character length
2015-09-18 8:54 [PATCH] Staging: android: Fix 80 character length Punit Vara
@ 2015-09-19 2:40 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-09-19 2:40 UTC (permalink / raw)
To: Punit Vara; +Cc: devel, arve, riandrews, linux-kernel
On Fri, Sep 18, 2015 at 02:24:16PM +0530, Punit Vara wrote:
> This patch is to the Kconfig file which fixes up lines which
> exceeded the standard 80 character limitation.
> This file also fixes up 3 warnings regarding paragraph.
Why is this indented?
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/staging/android/Kconfig | 28 ++++++++++++++++------------
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 42b1512..f4a2371 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -12,7 +12,8 @@ config ASHMEM
> file-based API.
>
> It is, in theory, a good memory allocator for low-memory devices,
> - because it can discard shared memory units when under memory pressure.
This is 80 characters wide, no need to change it.
> + because it can discard shared memory units when under memory
> + pressure.
>
> config ANDROID_TIMED_OUTPUT
> bool "Timed output class driver"
> @@ -24,19 +25,20 @@ config ANDROID_TIMED_GPIO
> depends on ANDROID_TIMED_OUTPUT
> default n
> ---help---
> - Unlike generic gpio is to allow programs to access and manipulate gpio
> - registers from user space, timed output/gpio is a system to allow changing
> - a gpio pin and restore it automatically after a specified timeout.
> + Unlike generic gpio is to allow programs to access and manipulate
> + gpio registers from user space, timed output/gpio is a system to
> + allow changing a gpio pin and restore it automatically after a
> + specified timeout.
>
> config ANDROID_LOW_MEMORY_KILLER
> bool "Android Low Memory Killer"
> ---help---
> - Registers processes to be killed when low memory conditions, this is useful
> - as there is no particular swap space on android.
> + Registers processes to be killed when low memory conditions, this
> + is useful as there is no particular swap space on android.
>
> - The registered process will kills according to the priorities in android init
> - scripts (/init.rc), and it defines priority values with minimum free memory size
> - for each priority.
> + The registered process will kills according to the priorities in
> + android init scripts (/init.rc), and it defines priority values with
> + minimum free memory size for each priority.
>
> config SYNC
> bool "Synchronization framework"
> @@ -44,8 +46,9 @@ config SYNC
> select ANON_INODES
> select DMA_SHARED_BUFFER
> ---help---
> - This option enables the framework for synchronization between multiple
This is also ok.
> - drivers. Sync implementations can take advantage of hardware
> + This option enables the framework for synchronization between
> + multiple drivers.
> + Sync implementations can take advantage of hardware
> synchronization built into devices like GPUs.
>
> config SW_SYNC
> @@ -54,7 +57,8 @@ config SW_SYNC
> depends on SYNC
> ---help---
> A sync object driver that uses a 32bit counter to coordinate
> - synchronization. Useful when there is no hardware primitive backing
And this is just fine, why change it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-19 4:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 8:54 [PATCH] Staging: android: Fix 80 character length Punit Vara
2015-09-19 2:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox