From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753047AbbISE7K (ORCPT ); Sat, 19 Sep 2015 00:59:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45014 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbbISE7J (ORCPT ); Sat, 19 Sep 2015 00:59:09 -0400 Date: Fri, 18 Sep 2015 19:40:50 -0700 From: Greg KH To: Punit Vara Cc: devel@driverdev.osuosl.org, arve@android.com, riandrews@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: android: Fix 80 character length Message-ID: <20150919024050.GA21258@kroah.com> References: <1442566456-3647-1-git-send-email-punitvara@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442566456-3647-1-git-send-email-punitvara@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 02:24:16PM +0530, Punit Vara wrote: > This patch is to the Kconfig file which fixes up lines which > exceeded the standard 80 character limitation. > This file also fixes up 3 warnings regarding paragraph. Why is this indented? > > Signed-off-by: Punit Vara > --- > drivers/staging/android/Kconfig | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig > index 42b1512..f4a2371 100644 > --- a/drivers/staging/android/Kconfig > +++ b/drivers/staging/android/Kconfig > @@ -12,7 +12,8 @@ config ASHMEM > file-based API. > > It is, in theory, a good memory allocator for low-memory devices, > - because it can discard shared memory units when under memory pressure. This is 80 characters wide, no need to change it. > + because it can discard shared memory units when under memory > + pressure. > > config ANDROID_TIMED_OUTPUT > bool "Timed output class driver" > @@ -24,19 +25,20 @@ config ANDROID_TIMED_GPIO > depends on ANDROID_TIMED_OUTPUT > default n > ---help--- > - Unlike generic gpio is to allow programs to access and manipulate gpio > - registers from user space, timed output/gpio is a system to allow changing > - a gpio pin and restore it automatically after a specified timeout. > + Unlike generic gpio is to allow programs to access and manipulate > + gpio registers from user space, timed output/gpio is a system to > + allow changing a gpio pin and restore it automatically after a > + specified timeout. > > config ANDROID_LOW_MEMORY_KILLER > bool "Android Low Memory Killer" > ---help--- > - Registers processes to be killed when low memory conditions, this is useful > - as there is no particular swap space on android. > + Registers processes to be killed when low memory conditions, this > + is useful as there is no particular swap space on android. > > - The registered process will kills according to the priorities in android init > - scripts (/init.rc), and it defines priority values with minimum free memory size > - for each priority. > + The registered process will kills according to the priorities in > + android init scripts (/init.rc), and it defines priority values with > + minimum free memory size for each priority. > > config SYNC > bool "Synchronization framework" > @@ -44,8 +46,9 @@ config SYNC > select ANON_INODES > select DMA_SHARED_BUFFER > ---help--- > - This option enables the framework for synchronization between multiple This is also ok. > - drivers. Sync implementations can take advantage of hardware > + This option enables the framework for synchronization between > + multiple drivers. > + Sync implementations can take advantage of hardware > synchronization built into devices like GPUs. > > config SW_SYNC > @@ -54,7 +57,8 @@ config SW_SYNC > depends on SYNC > ---help--- > A sync object driver that uses a 32bit counter to coordinate > - synchronization. Useful when there is no hardware primitive backing And this is just fine, why change it? thanks, greg k-h