From: Greg KH <gregkh@linuxfoundation.org>
To: Anjali Menon <cse.anjalimenon@gmail.com>
Cc: oleg.drokin@intel.com, jinshan.xiong@intel.com,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: lustre: lustre: lclient: Removed the else statement
Date: Fri, 18 Sep 2015 19:44:26 -0700 [thread overview]
Message-ID: <20150919024426.GG21258@kroah.com> (raw)
In-Reply-To: <1442506481-8754-1-git-send-email-cse.anjalimenon@gmail.com>
On Thu, Sep 17, 2015 at 09:44:41PM +0530, Anjali Menon wrote:
> Removed the else statement along with some unwanted brackets
> to fix the following coding style warning detected by
> checkpatch.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
> drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> index ab6cb41..23092fc 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> @@ -836,7 +836,7 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
> *exceed = 1;
> }
> return result;
> - } else {
> + }
> /*
> * region is within kms and, hence, within real file
> * size (A). We need to increase i_size to cover the
This change isn't correct, look at how the code now looks :(
prev parent reply other threads:[~2015-09-19 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 16:14 [PATCH] staging: lustre: lustre: lclient: Removed the else statement Anjali Menon
2015-09-17 16:51 ` Jaime Arrocha
2015-09-19 2:44 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150919024426.GG21258@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cse.anjalimenon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=jinshan.xiong@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox