From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755121AbbISFCJ (ORCPT ); Sat, 19 Sep 2015 01:02:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45092 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754232AbbISE7N (ORCPT ); Sat, 19 Sep 2015 00:59:13 -0400 Date: Fri, 18 Sep 2015 19:44:26 -0700 From: Greg KH To: Anjali Menon Cc: oleg.drokin@intel.com, jinshan.xiong@intel.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: lustre: lustre: lclient: Removed the else statement Message-ID: <20150919024426.GG21258@kroah.com> References: <1442506481-8754-1-git-send-email-cse.anjalimenon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442506481-8754-1-git-send-email-cse.anjalimenon@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2015 at 09:44:41PM +0530, Anjali Menon wrote: > Removed the else statement along with some unwanted brackets > to fix the following coding style warning detected by > checkpatch. > > WARNING: else is not generally useful after a break or return > > Signed-off-by: Anjali Menon > --- > drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c > index ab6cb41..23092fc 100644 > --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c > +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c > @@ -836,7 +836,7 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj, > *exceed = 1; > } > return result; > - } else { > + } > /* > * region is within kms and, hence, within real file > * size (A). We need to increase i_size to cover the This change isn't correct, look at how the code now looks :(