[PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

[PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

[Luis de Bethencourt]

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
 drivers/usb/host/ehci-spear.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
index 34e1474..3c4e525 100644
--- a/drivers/usb/host/ehci-spear.c
+++ b/drivers/usb/host/ehci-spear.c
@@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
 	{ .compatible = "st,spear600-ehci", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, spear_ehci_id_table);
 
 static struct platform_driver spear_ehci_hcd_driver = {
 	.probe		= spear_ehci_hcd_drv_probe,
-- 
2.4.6

Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

[Alan Stern]

On Fri, 18 Sep 2015, Luis de Bethencourt wrote:

> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/usb/host/ehci-spear.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
> index 34e1474..3c4e525 100644
> --- a/drivers/usb/host/ehci-spear.c
> +++ b/drivers/usb/host/ehci-spear.c
> @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
>  	{ .compatible = "st,spear600-ehci", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, spear_ehci_id_table);
>  
>  static struct platform_driver spear_ehci_hcd_driver = {
>  	.probe		= spear_ehci_hcd_drv_probe,
> 

Acked-by: Alan Stern <stern@rowland.harvard.edu>

Also for V2 of patches 3/4 and 4/4.

Alan Stern

Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

[Greg Kroah-Hartman]

On Fri, Sep 18, 2015 at 09:14:52PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/usb/host/ehci-spear.c | 1 +
>  1 file changed, 1 insertion(+)

Ugh, what a mess, please resend the whole series when you fix up a patch
in it as this is hard to figure out what to do.

And can you "thread" the patch series properly?  That makes it much
easier for me to apply them as I can group them correctly.

thanks,

greg k-h