* [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver
@ 2015-09-18 19:14 Luis de Bethencourt
2015-09-18 19:34 ` Alan Stern
2015-09-19 3:03 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2015-09-18 19:14 UTC (permalink / raw)
To: linux-kernel; +Cc: Alan Stern, Greg Kroah-Hartman, linux-usb
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
drivers/usb/host/ehci-spear.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
index 34e1474..3c4e525 100644
--- a/drivers/usb/host/ehci-spear.c
+++ b/drivers/usb/host/ehci-spear.c
@@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
{ .compatible = "st,spear600-ehci", },
{ },
};
+MODULE_DEVICE_TABLE(of, spear_ehci_id_table);
static struct platform_driver spear_ehci_hcd_driver = {
.probe = spear_ehci_hcd_drv_probe,
--
2.4.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver
2015-09-18 19:14 [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-18 19:34 ` Alan Stern
2015-09-19 3:03 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Alan Stern @ 2015-09-18 19:34 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: linux-kernel, Greg Kroah-Hartman, linux-usb
On Fri, 18 Sep 2015, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> drivers/usb/host/ehci-spear.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
> index 34e1474..3c4e525 100644
> --- a/drivers/usb/host/ehci-spear.c
> +++ b/drivers/usb/host/ehci-spear.c
> @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
> { .compatible = "st,spear600-ehci", },
> { },
> };
> +MODULE_DEVICE_TABLE(of, spear_ehci_id_table);
>
> static struct platform_driver spear_ehci_hcd_driver = {
> .probe = spear_ehci_hcd_drv_probe,
>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Also for V2 of patches 3/4 and 4/4.
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver
2015-09-18 19:14 [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-18 19:34 ` Alan Stern
@ 2015-09-19 3:03 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2015-09-19 3:03 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: linux-kernel, Alan Stern, linux-usb
On Fri, Sep 18, 2015 at 09:14:52PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> drivers/usb/host/ehci-spear.c | 1 +
> 1 file changed, 1 insertion(+)
Ugh, what a mess, please resend the whole series when you fix up a patch
in it as this is hard to figure out what to do.
And can you "thread" the patch series properly? That makes it much
easier for me to apply them as I can group them correctly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-19 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 19:14 [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-18 19:34 ` Alan Stern
2015-09-19 3:03 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox