From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754873AbbISKGe (ORCPT ); Sat, 19 Sep 2015 06:06:34 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34931 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754767AbbISKGc (ORCPT ); Sat, 19 Sep 2015 06:06:32 -0400 Date: Sat, 19 Sep 2015 11:06:22 +0100 From: Lee Jones To: Bjorn Andersson Cc: Milo Kim , Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Werner Johansson Subject: Re: [PATCH] backlight: lp855x: Make sure props struct is zeroed Message-ID: <20150919100622.GJ3218@x1> References: <1440697275-4469-1-git-send-email-bjorn.andersson@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440697275-4469-1-git-send-email-bjorn.andersson@sonymobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Aug 2015, Bjorn Andersson wrote: > From: Werner Johansson > > The driver occasionally got stuck in suspend mode or other strange > states as those parts of the props struct were never initialized. > > Signed-off-by: Werner Johansson > Signed-off-by: Bjorn Andersson > --- > drivers/video/backlight/lp855x_bl.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c > index 88116b493f3b..0a7f88ce1ab0 100644 > --- a/drivers/video/backlight/lp855x_bl.c > +++ b/drivers/video/backlight/lp855x_bl.c > @@ -282,6 +282,7 @@ static int lp855x_backlight_register(struct lp855x *lp) > struct lp855x_platform_data *pdata = lp->pdata; > const char *name = pdata->name ? : DEFAULT_BL_NAME; > > + memset(&props, 0, sizeof(props)); > props.type = BACKLIGHT_PLATFORM; > props.max_brightness = MAX_BRIGHTNESS; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog