From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754875AbbISKJm (ORCPT ); Sat, 19 Sep 2015 06:09:42 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:35875 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbbISKJj (ORCPT ); Sat, 19 Sep 2015 06:09:39 -0400 Date: Sat, 19 Sep 2015 12:09:34 +0200 From: Ingo Molnar To: Mathieu Poirier Cc: gregkh@linuxfoundation.org, a.p.zijlstra@chello.nl, alexander.shishkin@linux.intel.com, acme@kernel.org, mingo@redhat.com, corbet@lwn.net, adrian.hunter@intel.com, zhang.chunyan@linaro.org, mike.leach@arm.com, tor@ti.com, al.grant@arm.com, pawel.moll@arm.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 20/20] coresight: updating documentation to reflect integration with perf Message-ID: <20150919100934.GA31274@gmail.com> References: <1442593594-10665-1-git-send-email-mathieu.poirier@linaro.org> <1442593594-10665-21-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442593594-10665-21-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks like a pretty useful feature all around. While reading the description I noticed a few typos: * Mathieu Poirier wrote: > +Regardless of the amnout ETM/PTM IP block in a system (usually equal to the > +amount of processor core), the "cs_etm" PMU will be listed only once. s/amnout/amount > +Tracing limited to user and kernel space can also be used to narrow the amount > +of collected tracers: s/tracers/traces > +The Coresight PMUs can be configured to work in "full trace" or "snapshot" mode. > +In full trace mode trade acquisition is enable from beginning to end with trace > +data being recorded continuously: s/trade acquisition/trace acquisition s/is enable from/is enabled from > +Since this can lead to a significant amount of data and that some device are > +limited in disk space snapshot mode can be used instead. s/and that some device are limited in disk space/ and because some devices are limited in disk space > +Trace data collected during trace runs end up in the centennial "perf.data" > +file. hey, perf isn't 100 years old! :-) s/centennial/central ? Also, 'data' is singular in this context, so I think: s/data collected during trace runs end up in the /data collected during trace runs ends up in the > [...] Trace configuration information necessary for trace decoding are also > +embedded in the "perf.data" file. s/are/is > Two new headers, 'PERF_RECORD_AUXTRACE_INFO' > +and 'PERF_RECORD_AUXTRACE' have been added to list of event types in order to > +find out where the different sections start. s/to list of event types /to the list of event types > + > +It is worth nothing that a set of metadata information exists for each tracer > +that participated in a trace run. [...] s/nothing /noting As such if 5 processors have been engaged, > +5 set of metadata will be found in the perf.data file. s/5 set of metadata /5 sets of metadata > +Metadata information is collected directly from the ETM/PTM management registers > +using the sysFS interface. Since there is not way for the perf command line > +tool to associate a CPU with a tracer, a symbolic link has been created between > +the cs_etm sysFS event directory and each Coresight tracer: s/there is not way /there is no way > +As with the perf method described above, a coresight sink needs to be identify > +before trace collection can commence. Btw., 'Coresight' is spelled in two different ways throughout this document: capitalized and non-capitalized. Please pick one variant and use it consistently. > any given moment. As a generic operation, all device pertaining to the sink > -class will have an "active" entry in sysfs: s/all device pertaining to /all devices pertaining to Thanks, Ingo