From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755397AbbITEUU (ORCPT ); Sun, 20 Sep 2015 00:20:20 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35548 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbbITEUP (ORCPT ); Sun, 20 Sep 2015 00:20:15 -0400 Date: Sun, 20 Sep 2015 05:20:12 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH 2/2] mfd: rt5033: Remove unnecessary MODULE_ALIAS() Message-ID: <20150920042012.GX3039@x1> References: <1440975510-21835-1-git-send-email-javier@osg.samsung.com> <1440975510-21835-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440975510-21835-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Aug 2015, Javier Martinez Canillas wrote: > The driver has a I2C device id table that is used to create the module > aliases which already contains a "rt5033". So the alias is not needed. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/rt5033.c | 1 - > 1 file changed, 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c > index d60f91619c4a..110de2a583af 100644 > --- a/drivers/mfd/rt5033.c > +++ b/drivers/mfd/rt5033.c > @@ -137,7 +137,6 @@ static struct i2c_driver rt5033_driver = { > }; > module_i2c_driver(rt5033_driver); > > -MODULE_ALIAS("i2c:rt5033"); > MODULE_DESCRIPTION("Richtek RT5033 multi-function core driver"); > MODULE_AUTHOR("Beomho Seo "); > MODULE_LICENSE("GPL"); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog